From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Hugo Villeneuve <hugo@hugovil.com>,
Alessandro Zummo <a.zummo@towertech.it>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
Hugo Villeneuve <hvilleneuve@dimonoff.com>,
linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtc: pcf2127: fix bug when reading alarm registers
Date: Tue, 15 Feb 2022 23:35:57 +0100 [thread overview]
Message-ID: <164496455010.67358.12781580107745972027.b4-ty@bootlin.com> (raw)
In-Reply-To: <20220208162908.3182581-1-hugo@hugovil.com>
On Tue, 8 Feb 2022 11:29:07 -0500, Hugo Villeneuve wrote:
> From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
>
> The first bug is that reading the 5 alarm registers results in a read
> operation of 20 bytes. The reason is because the destination buffer is
> defined as an array of "unsigned int", and we use the sizeof()
> operator on this array to define the bulk read count.
>
> [...]
Applied, thanks!
[1/1] rtc: pcf2127: fix bug when reading alarm registers
commit: 73ce05302007eece23a6acb7dc124c92a2209087
Best regards,
--
Alexandre Belloni <alexandre.belloni@bootlin.com>
prev parent reply other threads:[~2022-02-15 22:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-08 16:29 [PATCH] rtc: pcf2127: fix bug when reading alarm registers Hugo Villeneuve
2022-02-15 22:35 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=164496455010.67358.12781580107745972027.b4-ty@bootlin.com \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=hugo@hugovil.com \
--cc=hvilleneuve@dimonoff.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).