From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF037C433F5 for ; Thu, 24 Mar 2022 09:28:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348258AbiCXJ3h (ORCPT ); Thu, 24 Mar 2022 05:29:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240807AbiCXJ3e (ORCPT ); Thu, 24 Mar 2022 05:29:34 -0400 Received: from m12-13.163.com (m12-13.163.com [220.181.12.13]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B35645D19B for ; Thu, 24 Mar 2022 02:28:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=XWiAQ+Z5d0xuLBcjww QPEKbQplidblsEpe/wGww446k=; b=BWCufjrBPVlhGS5mk3IwvgOK1Td0q6hxUi jnLEM+Z+ZiaJ+1Ku36v+rlg9aicj+DvTUYXRScdDkakNnGdoWuLu3PI9Y5/Wo6DH haRBevkUFsHnYfaIQgiigB8sDXrdsCpwSDrKurXijJQNJhwiRST9/JXk8CPeBl82 QfhgxNrUM= Received: from localhost (unknown [159.226.95.33]) by smtp9 (Coremail) with SMTP id DcCowACHeGSbOTxiqb57CQ--.3994S2; Thu, 24 Mar 2022 17:27:55 +0800 (CST) From: QintaoShen To: colyli@suse.de Cc: linux-bcache@vger.kernel.org, kent.overstreet@gmail.com, linux-kernel@vger.kernel.org, QintaoShen Subject: [PATCH v1] bcache: Check for NULL return of kzalloc() Date: Thu, 24 Mar 2022 17:27:54 +0800 Message-Id: <1648114074-10045-1-git-send-email-unSimple1993@163.com> X-Mailer: git-send-email 2.7.4 X-CM-TRANSID: DcCowACHeGSbOTxiqb57CQ--.3994S2 X-Coremail-Antispam: 1Uf129KBjvdXoWrtw4rury5Zw4fGr4DCw17Wrg_yoWfJrb_W3 WfZrn2grZ0kr1IgF42vr13XrWUta1DZF9YvFsxtr1Sqasxu3Z3Wr10vr45JayfGFWrZay7 Z34UJw1fuw1SkjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7VUUPrc5UUUUU== X-Originating-IP: [159.226.95.33] X-CM-SenderInfo: 5xqvxz5sohimizt6il2tof0z/xtbBdRvNH1aEB0SbYgAAsU Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org kzalloc() is a memory allocation function which may return a NULL pointer. Therefore, it is better to check the return value of kzalloc() to avoid potential NULL-pointer dereference. Signed-off-by: QintaoShen --- drivers/md/bcache/request.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c index fdd0194..232ffe3 100644 --- a/drivers/md/bcache/request.c +++ b/drivers/md/bcache/request.c @@ -1105,6 +1105,9 @@ static void detached_dev_do_request(struct bcache_device *d, struct bio *bio, * which would call closure_get(&dc->disk.cl) */ ddip = kzalloc(sizeof(struct detached_dev_io_private), GFP_NOIO); + if (!ddpp) + return ; + ddip->d = d; /* Count on the bcache device */ ddip->orig_bdev = orig_bdev; -- 2.7.4