From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Aaron Lu <aaron.lu@intel.com>
Cc: Lee Jones <lee.jones@linaro.org>,
Jacob Pan <jacob.jun.pan@linux.intel.com>,
Yegnesh Iyer <yegnesh.s.iyer@intel.com>,
linux-acpi@vger.kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] ACPI / PMIC: AXP288: support virtual GPIO in ACPI table
Date: Mon, 24 Nov 2014 02:06:05 +0100 [thread overview]
Message-ID: <1648486.coeVgHKNdn@vostro.rjw.lan> (raw)
In-Reply-To: <1416553911-22990-4-git-send-email-aaron.lu@intel.com>
On Friday, November 21, 2014 03:11:51 PM Aaron Lu wrote:
> The same virtual GPIO strategy is also used for the AXP288 PMIC in that
> various control methods that are used to do power rail handling and
> sensor reading/setting will touch GPIO fields defined under the PMIC
> device. The GPIO fileds are only defined by the ACPI code while the
> actual hardware doesn't really have a GPIO controller, but to make those
> control method execution succeed, we have to install a GPIO handler for
> the PMIC device handle. Since we do not need the virtual GPIO strategy,
> we can simply do nothing in that handler.
>
> Signed-off-by: Aaron Lu <aaron.lu@intel.com>
> ---
> drivers/acpi/pmic/intel_pmic_xpower.c | 27 +++++++++++++++++++++++----
> 1 file changed, 23 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/acpi/pmic/intel_pmic_xpower.c b/drivers/acpi/pmic/intel_pmic_xpower.c
> index 6c4d6ce0cff1..480c41c36444 100644
> --- a/drivers/acpi/pmic/intel_pmic_xpower.c
> +++ b/drivers/acpi/pmic/intel_pmic_xpower.c
> @@ -251,13 +251,32 @@ static struct intel_pmic_opregion_data intel_xpower_pmic_opregion_data = {
> .thermal_table_count = ARRAY_SIZE(thermal_table),
> };
>
> +static acpi_status intel_xpower_pmic_gpio_handler(u32 function,
> + acpi_physical_address address, u32 bit_width, u64 *value,
> + void *handler_context, void *region_context)
> +{
> + return AE_OK;
> +}
>
> static int intel_xpower_pmic_opregion_probe(struct platform_device *pdev)
> {
> - struct axp20x_dev *axp20x = dev_get_drvdata(pdev->dev.parent);
> - return intel_pmic_install_opregion_handler(&pdev->dev,
> - ACPI_HANDLE(pdev->dev.parent), axp20x->regmap,
> - &intel_xpower_pmic_opregion_data);
> + struct device *parent = pdev->dev.parent;
> + struct axp20x_dev *axp20x = dev_get_drvdata(parent);
> + acpi_status status;
> + int result;
> +
> + result = intel_pmic_install_opregion_handler(&pdev->dev,
> + ACPI_HANDLE(parent), axp20x->regmap,
> + &intel_xpower_pmic_opregion_data);
> + if (!result) {
> + status = acpi_install_address_space_handler(
> + ACPI_HANDLE(parent), ACPI_ADR_SPACE_GPIO,
> + intel_xpower_pmic_gpio_handler, NULL, NULL);
So here we have a problem, because we can't unregister the opregion handler
registered above if this fails. Not nice.
> + if (ACPI_FAILURE(status))
> + result = -ENODEV;
> + }
> +
> + return result;
> }
>
> static struct platform_driver intel_xpower_pmic_opregion_driver = {
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
next prev parent reply other threads:[~2014-11-24 0:44 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-21 7:11 [PATCH v3 0/3] Support PMIC operation region for CrystalCove and XPower Aaron Lu
2014-11-21 7:11 ` [PATCH v3 1/3] ACPI / PMIC: support PMIC operation region for CrystalCove Aaron Lu
2014-11-24 0:59 ` Rafael J. Wysocki
2014-11-24 5:55 ` Aaron Lu
2014-11-24 9:21 ` [PATCH v3 1/3 updated] " Aaron Lu
2014-11-21 7:11 ` [PATCH v3 2/3] ACPI / PMIC: support PMIC operation region for XPower AXP288 Aaron Lu
2014-11-24 1:04 ` Rafael J. Wysocki
2014-11-24 9:24 ` [PATCH v3 updated " Aaron Lu
2014-11-21 7:11 ` [PATCH v3 3/3] ACPI / PMIC: AXP288: support virtual GPIO in ACPI table Aaron Lu
2014-11-24 1:06 ` Rafael J. Wysocki [this message]
2014-11-24 6:01 ` Aaron Lu
2014-11-24 9:32 ` [PATCH v3 updated " Aaron Lu
2014-11-24 15:19 ` Rafael J. Wysocki
2014-11-25 1:44 ` Zheng, Lv
2014-11-25 12:01 ` Aaron Lu
2014-11-25 20:34 ` Rafael J. Wysocki
2014-11-25 1:47 ` [PATCH v3 0/3] Support PMIC operation region for CrystalCove and XPower Rafael J. Wysocki
2014-11-25 11:52 ` Aaron Lu
2014-11-25 20:41 ` Rafael J. Wysocki
2014-11-26 2:35 ` Aaron Lu
2014-11-26 2:44 ` Aaron Lu
2014-11-26 23:02 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1648486.coeVgHKNdn@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=aaron.lu@intel.com \
--cc=jacob.jun.pan@linux.intel.com \
--cc=lee.jones@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yegnesh.s.iyer@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).