From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 764A7C433F5 for ; Wed, 6 Apr 2022 14:51:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235273AbiDFOxP (ORCPT ); Wed, 6 Apr 2022 10:53:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235072AbiDFOwq (ORCPT ); Wed, 6 Apr 2022 10:52:46 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4F911925BA; Wed, 6 Apr 2022 04:28:19 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 15480CE22A0; Wed, 6 Apr 2022 11:28:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7CD01C385A7; Wed, 6 Apr 2022 11:28:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649244496; bh=eAgbv9qgg274UEIYdexRlug70MVocnKwK9vWroUZko0=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=pIa4E0+UEbA/SOqY2lPQRFBLbmmUL0xYSP6M7jkkfkqwJf9TgYsN473SXmo2sHjlU XLWBEYPihuWGVMM5W7V8bvRJweLXMypfFYcCgSrqAJ4zfmBjnH97NpR0pb8nqL2KU2 yFdkNcWhloCeDF6i6GhqjHHRKFd/Dkh1vCN+0mfC3XqAlANEpmKz9jiiXF8eovm3U3 9EJ+TqSTXdN7C4Msd+UYwvdf/9Pzl1GHAKAnxFBIVrMvyXe60cNfJakGXXwRfPQjB+ xYII7hf8ECE4TLJb2sPpnQxUA17myXM3T0xI6zDVH9m/OhT0SqR/oMbFxrLazompDI YzxNMSJJlQ3/A== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [v3,2/2] rtl8xxxu: fill up txrate info for gen1 chips From: Kalle Valo In-Reply-To: <20220325035735.4745-3-chris.chiu@canonical.com> References: <20220325035735.4745-3-chris.chiu@canonical.com> To: Chris Chiu Cc: Jes.Sorensen@gmail.com, davem@davemloft.net, kuba@kernel.org, code@reto-schneider.ch, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Chris Chiu User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <164924448932.19026.12333806311207815732.kvalo@kernel.org> Date: Wed, 6 Apr 2022 11:28:14 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Chris Chiu wrote: > RTL8188CUS/RTL8192CU(gen1) don't support rate adaptive report hence > no real txrate info can be retrieved. The vendor driver reports the > highest rate in HT capabilities from the IEs to avoid empty txrate. > This commit initiates the txrate information with the highest supported > rate negotiated with AP. The gen2 chip keeps update the txrate from > the rate adaptive reports, and gen1 chips at least have non-NULL txrate > after associated. > > Signed-off-by: Chris Chiu You ignored Reto's comment in v2 about misspelling of adaptive, but I'll fix that during commit. -- https://patchwork.kernel.org/project/linux-wireless/patch/20220325035735.4745-3-chris.chiu@canonical.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches