From: Rob Herring <robh@kernel.org>
To: Corentin Labbe <clabbe@baylibre.com>
Cc: devicetree@vger.kernel.org, robh+dt@kernel.org,
herbert@gondor.apana.org.au, krzysztof.kozlowski+dt@linaro.org,
linux-arm-kernel@lists.infradead.org,
linux-crypto@vger.kernel.org, heiko@sntech.de,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 24/33] dt-bindings: crypto: convert rockchip-crypto to YAML
Date: Thu, 14 Apr 2022 08:28:14 -0500 [thread overview]
Message-ID: <1649942894.398402.1863785.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20220413190713.1427956-25-clabbe@baylibre.com>
On Wed, 13 Apr 2022 19:07:04 +0000, Corentin Labbe wrote:
> Convert rockchip-crypto to YAML.
>
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> ---
> .../crypto/rockchip,rk3288-crypto.yaml | 66 +++++++++++++++++++
> .../bindings/crypto/rockchip-crypto.txt | 28 --------
> 2 files changed, 66 insertions(+), 28 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/crypto/rockchip,rk3288-crypto.yaml
> delete mode 100644 Documentation/devicetree/bindings/crypto/rockchip-crypto.txt
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
./Documentation/devicetree/bindings/crypto/rockchip,rk3288-crypto.yaml:30:7: [error] duplication of key "const" in mapping (key-duplicates)
./Documentation/devicetree/bindings/crypto/rockchip,rk3288-crypto.yaml:31:7: [error] duplication of key "const" in mapping (key-duplicates)
./Documentation/devicetree/bindings/crypto/rockchip,rk3288-crypto.yaml:32:7: [error] duplication of key "const" in mapping (key-duplicates)
dtschema/dtc warnings/errors:
make[1]: *** Deleting file 'Documentation/devicetree/bindings/crypto/rockchip,rk3288-crypto.example.dts'
Documentation/devicetree/bindings/crypto/rockchip,rk3288-crypto.yaml: found duplicate key "const" with value "hclk" (original value: "aclk")
make[1]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/crypto/rockchip,rk3288-crypto.example.dts] Error 1
make[1]: *** Waiting for unfinished jobs....
Traceback (most recent call last):
File "/usr/local/bin/dt-doc-validate", line 25, in check_doc
testtree = dtschema.load(filename, line_number=line_number)
File "/usr/local/lib/python3.8/dist-packages/dtschema/lib.py", line 912, in load
return yaml.load(f.read())
File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/main.py", line 434, in load
return constructor.get_single_data()
File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py", line 121, in get_single_data
return self.construct_document(node)
File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py", line 131, in construct_document
for _dummy in generator:
File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py", line 674, in construct_yaml_map
value = self.construct_mapping(node)
File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py", line 445, in construct_mapping
return BaseConstructor.construct_mapping(self, node, deep=deep)
File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py", line 263, in construct_mapping
if self.check_mapping_key(node, key_node, mapping, key, value):
File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py", line 294, in check_mapping_key
raise DuplicateKeyError(*args)
ruamel.yaml.constructor.DuplicateKeyError: while constructing a mapping
in "<unicode string>", line 29, column 7
found duplicate key "const" with value "hclk" (original value: "aclk")
in "<unicode string>", line 30, column 7
To suppress this check see:
http://yaml.readthedocs.io/en/latest/api.html#duplicate-keys
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/bin/dt-doc-validate", line 74, in <module>
ret = check_doc(f)
File "/usr/local/bin/dt-doc-validate", line 30, in check_doc
print(filename + ":", exc.path[-1], exc.message, file=sys.stderr)
AttributeError: 'DuplicateKeyError' object has no attribute 'path'
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/crypto/rockchip,rk3288-crypto.yaml: ignoring, error parsing file
make: *** [Makefile:1401: dt_binding_check] Error 2
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2022-04-14 13:57 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-13 19:06 [PATCH v5 00/33] crypto: rockchip: permit to pass self-tests Corentin Labbe
2022-04-13 19:06 ` [PATCH v5 01/33] crypto: rockchip: use dev_err for error message about interrupt Corentin Labbe
2022-04-13 19:06 ` [PATCH v5 02/33] crypto: rockchip: do not use uninitialized variable Corentin Labbe
2022-04-13 19:06 ` [PATCH v5 03/33] crypto: rockchip: do not do custom power management Corentin Labbe
2022-04-13 19:06 ` [PATCH v5 04/33] crypto: rockchip: fix privete/private typo Corentin Labbe
2022-04-13 19:06 ` [PATCH v5 05/33] crypto: rockchip: do not store mode globally Corentin Labbe
2022-04-13 19:06 ` [PATCH v5 06/33] crypto: rockchip: add fallback for cipher Corentin Labbe
2022-04-13 19:06 ` [PATCH v5 07/33] crypto: rockchip: add fallback for ahash Corentin Labbe
2022-04-13 19:06 ` [PATCH v5 08/33] crypto: rockchip: better handle cipher key Corentin Labbe
2022-04-13 19:06 ` [PATCH v5 09/33] crypto: rockchip: remove non-aligned handling Corentin Labbe
2022-04-13 19:06 ` [PATCH v5 10/33] crypto: rockchip: rework by using crypto_engine Corentin Labbe
2022-04-13 19:06 ` [PATCH v5 11/33] crypto: rockchip: rewrite type Corentin Labbe
2022-04-13 19:06 ` [PATCH v5 12/33] crypto: rockchip: add debugfs Corentin Labbe
2022-04-13 19:06 ` [PATCH v5 13/33] crypto: rockchip: introduce PM Corentin Labbe
2022-04-13 19:06 ` [PATCH v5 14/33] crypto: rockchip: handle reset also in PM Corentin Labbe
2022-04-13 19:06 ` [PATCH v5 15/33] crypto: rockchip: use clk_bulk to simplify clock management Corentin Labbe
2022-04-13 19:06 ` [PATCH v5 16/33] crypto: rockchip: add myself as maintainer Corentin Labbe
2022-04-13 19:06 ` [PATCH v5 17/33] crypto: rockchip: use read_poll_timeout Corentin Labbe
2022-04-13 19:06 ` [PATCH v5 18/33] crypto: rockchip: fix style issue Corentin Labbe
2022-04-13 19:06 ` [PATCH v5 19/33] crypto: rockchip: add support for rk3328 Corentin Labbe
2022-04-13 19:07 ` [PATCH v5 20/33] crypto: rockchip: rename ablk functions to cipher Corentin Labbe
2022-04-13 19:07 ` [PATCH v5 21/33] crypto: rockchip: rework rk_handle_req function Corentin Labbe
2022-04-13 19:07 ` [PATCH v5 22/33] crypto: rockchip: use a rk_crypto_info variable instead of lot of indirection Corentin Labbe
2022-04-13 19:07 ` [PATCH v5 23/33] crypto: rockchip: use the rk_crypto_info given as parameter Corentin Labbe
2022-04-13 19:07 ` [PATCH v5 24/33] dt-bindings: crypto: convert rockchip-crypto to YAML Corentin Labbe
2022-04-13 19:31 ` Krzysztof Kozlowski
2022-04-19 11:09 ` LABBE Corentin
2022-04-19 11:54 ` Krzysztof Kozlowski
2022-04-14 13:28 ` Rob Herring [this message]
2022-04-13 19:07 ` [PATCH v5 25/33] dt-bindings: crypto: rockchip: convert to new driver bindings Corentin Labbe
2022-04-13 19:07 ` [PATCH v5 26/33] clk: rk3399: use proper crypto0 name Corentin Labbe
2022-04-13 19:07 ` [PATCH v5 27/33] arm64: dts: rockchip: add rk3328 crypto node Corentin Labbe
2022-04-13 19:07 ` [PATCH v5 28/33] arm64: dts: rockchip: rk3399: add " Corentin Labbe
2022-04-13 19:07 ` [PATCH v5 29/33] crypto: rockchip: store crypto_info in request context Corentin Labbe
2022-04-13 19:07 ` [PATCH v5 30/33] crypto: rockchip: Check for clocks numbers and their frequencies Corentin Labbe
2022-04-13 19:07 ` [PATCH v5 31/33] crypto: rockchip: rk_ahash_reg_init use crypto_info from parameter Corentin Labbe
2022-04-13 19:07 ` [PATCH v5 32/33] crypto: rockchip: permit to have more than one reset Corentin Labbe
2022-04-13 19:07 ` [PATCH v5 33/33] crypto: rockchip: Add support for RK3399 Corentin Labbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1649942894.398402.1863785.nullmailer@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=clabbe@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=herbert@gondor.apana.org.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).