From: "Alex Xu (Hello71)" <alex_y_xu@yahoo.ca>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Matthew Wilcox <willy@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
Daniel Colascione <dancol@google.com>,
linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Vlastimil Babka <vbabka@suse.cz>
Subject: Re: [PATCH] mm/smaps_rollup: return empty file for kthreads instead of ESRCH
Date: Thu, 14 Apr 2022 11:24:35 -0400 [thread overview]
Message-ID: <1649949601.z8rr7ed5qb.none@localhost> (raw)
In-Reply-To: <YlfFaPhNFWNP+1Z7@localhost.localdomain>
Excerpts from Alexey Dobriyan's message of April 14, 2022 2:55 am:
> Returning ESRCH is better so that programs don't waste time reading and
> closing empty files and instantiating useless inodes.
Yes, except ESRCH is not returned for open, it is returned for read.
> Of course it is different if this patch was sent as response to a regression.
I'm not sure I would classify it as a regression; I don't have an
existing program which broke, it is a new program which happens to use
some functionality which worked with a previous kernel. It is
theoretically possible that some program exists that currently uses
4.14, and will break if upgraded to 4.19+, but it is also possible that
some program exists that currently uses 4.19+ and will break if this
patch is applied.
Cheers,
Alex.
prev parent reply other threads:[~2022-04-14 15:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220413211357.26938-1-alex_y_xu.ref@yahoo.ca>
2022-04-13 21:13 ` [PATCH] mm/smaps_rollup: return empty file for kthreads instead of ESRCH Alex Xu (Hello71)
2022-04-13 21:27 ` Andrew Morton
2022-04-13 22:25 ` Alex Xu (Hello71)
2022-04-13 23:06 ` Andrew Morton
2022-04-14 3:23 ` Matthew Wilcox
2022-04-14 6:55 ` Alexey Dobriyan
2022-04-14 7:38 ` Vlastimil Babka
2022-04-27 20:34 ` Andrew Morton
2022-04-14 15:24 ` Alex Xu (Hello71) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1649949601.z8rr7ed5qb.none@localhost \
--to=alex_y_xu@yahoo.ca \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dancol@google.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).