From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB2B3C433EF for ; Thu, 21 Apr 2022 07:17:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1385415AbiDUHUn (ORCPT ); Thu, 21 Apr 2022 03:20:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1385238AbiDUHUm (ORCPT ); Thu, 21 Apr 2022 03:20:42 -0400 Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25207167F7 for ; Thu, 21 Apr 2022 00:17:54 -0700 (PDT) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id C5C283202148; Thu, 21 Apr 2022 03:17:52 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 21 Apr 2022 03:17:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1650525472; x= 1650611872; bh=oh+lVDVP/+27nOibF7WypJ0chLiLYDN0nl1H1n9lLY4=; b=d m77TTH1JWJj7vIQaF6775W/n2C3zNfwTPA4k1KzdGZ/s/z9MWZTo+eQt5AAvOf0X KM/i2AI78xvPMfO2Xgtxwin1fRGcfQtvuVQyqbTU1ZDsbU4kDhIhCTAJ4DbvCTHl nsQnH7gT1NKPaY78oy1kxwA+x8e+8wt0M9Gk+85bXZJ858iodaVNA45RXShgTmxX B1WJL/60OCFk1h4vAm2rVBaA/A9f+IWKOEdH3d9xC++biOvt3lkKA3EzLftXmqS9 gL5rJldx7+6fuytSy9ELE9lqxxhTrmfPjt8QWK+dsQ4fwjjzPPpqIxy/PrphHz3I diYpbvG8gpGQ4yfWt49yw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1650525472; x=1650611872; bh=oh+lVDVP/+27n OibF7WypJ0chLiLYDN0nl1H1n9lLY4=; b=TUXHqZmxiybHQlG5Re/yiFFXKW5Ne ayAp8vpntOwyFfhnaIyjEZn316OP7J94SfOrd6yfcNbBNSBYIU3VgxIIO2rcundV C4gojKFbBI41pqE7WbC7lowTUqvttE6WFGPAXx6ZScTOsDfAYd6H2nJ03jvVVvQY vIRTcIPLGzvCn/p+xQofJS6Phbxe4B6aA2slIge9GIs8d7FiCPQJ8qbWf4gTScd/ /1/A2BguGhF+vf2lLgdR16uBtByKnpVeSHpde+e3y02mmmd+ZilfkGmWgWByPRXK /KUXlUSzIgUN4L3uw5CmgLrWC5oLjIRxpJYFq/MB1+QrpH1Mv9jGMdihw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrtddugdduudelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeforgig ihhmvgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrf grthhtvghrnhepueeigefghfffffeifeehudeiuedvteegueefffevgfetvdffheehkeff vedufeeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 21 Apr 2022 03:17:51 -0400 (EDT) From: Maxime Ripard To: dri-devel@lists.freedesktop.org, Maxime Ripard , Miaoqian Lin , linux-kernel@vger.kernel.org, Daniel Vetter , Eric Anholt , Emma Anholt , David Airlie Cc: Maxime Ripard Subject: Re: (subset) [PATCH v3] drm/vc4: Use pm_runtime_resume_and_get to fix pm_runtime_get_sync() usage Date: Thu, 21 Apr 2022 09:17:49 +0200 Message-Id: <165052546651.683267.17613165683277248005.b4-ty@cerno.tech> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220420135008.2757-1-linmq006@gmail.com> References: <20220420132814.3sy2ojw3dxnd5tcz@houat> <20220420135008.2757-1-linmq006@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 20 Apr 2022 21:50:07 +0800, Miaoqian Lin wrote: > If the device is already in a runtime PM enabled state > pm_runtime_get_sync() will return 1. > > Also, we need to call pm_runtime_put_noidle() when pm_runtime_get_sync() > fails, so use pm_runtime_resume_and_get() instead. this function > will handle this. > > [...] Applied to drm/drm-misc (drm-misc-fixes). Thanks! Maxime