linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: luca.ceresoli@bootlin.com, linux-spi@vger.kernel.org
Cc: chris.ruehl@gtsys.com.hk, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	heiko@sntech.de
Subject: Re: [PATCH] spi: rockchip: fix missing error on unsupported SPI_CS_HIGH
Date: Mon, 25 Apr 2022 18:24:54 +0100	[thread overview]
Message-ID: <165090749413.584172.1969660470967557422.b4-ty@kernel.org> (raw)
In-Reply-To: <20220421213251.1077899-1-luca.ceresoli@bootlin.com>

On Thu, 21 Apr 2022 23:32:51 +0200, Luca Ceresoli wrote:
> The hardware (except for the ROCKCHIP_SPI_VER2_TYPE2 version) does not
> support active-high native chip selects. However if such a CS is configured
> the core does not error as it normally should, because the
> 'ctlr->use_gpio_descriptors = true' line in rockchip_spi_probe() makes the
> core set SPI_CS_HIGH in ctlr->mode_bits.
> 
> In such a case the spi-rockchip driver operates normally but produces an
> active-low chip select signal without notice.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: rockchip: fix missing error on unsupported SPI_CS_HIGH
      commit: d5d933f09ac326aebad85bfb787cc786ad477711

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

      reply	other threads:[~2022-04-25 17:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-21 21:32 [PATCH] spi: rockchip: fix missing error on unsupported SPI_CS_HIGH Luca Ceresoli
2022-04-25 17:24 ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=165090749413.584172.1969660470967557422.b4-ty@kernel.org \
    --to=broonie@kernel.org \
    --cc=chris.ruehl@gtsys.com.hk \
    --cc=heiko@sntech.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=luca.ceresoli@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).