From: Maninder Singh <maninder1.s@samsung.com>
To: Joe Perches <joe@perches.com>
Cc: "jeffrey.t.kirsher@intel.com" <jeffrey.t.kirsher@intel.com>,
"jesse.brandeburg@intel.com" <jesse.brandeburg@intel.com>,
"shannon.nelson@intel.com" <shannon.nelson@intel.com>,
"carolyn.wyborny@intel.com" <carolyn.wyborny@intel.com>,
"donald.c.skidmore@intel.com" <donald.c.skidmore@intel.com>,
"matthew.vick@intel.com" <matthew.vick@intel.com>,
"john.ronciak@intel.com" <john.ronciak@intel.com>,
"mitch.a.williams@intel.com" <mitch.a.williams@intel.com>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
PANKAJ MISHRA <pankaj.m@samsung.com>
Subject: Re: [PATCH 1/1] igb: Use ARRAY_SIZE instead fo sizeof(a)/sizeof(a[0])
Date: Tue, 30 Jun 2015 08:01:57 +0000 (GMT) [thread overview]
Message-ID: <1652907052.50321435651311854.JavaMail.weblogic@ep2mlwas04a> (raw)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=windows-1252, Size: 1104 bytes --]
Hi Joe,
>> Use ARRAY_SIZE instead fo sizeof(a)/sizeof(a[0])
>
>I think all of these #defines should be removed instead
>as they are all used only once.
If we replcase only ARRAY_SIZE then cood will look alike
to drivers/net/ethernet/intel/e1000e/phy.c
And if we have to remove these #defines , then we can also remove it from
drivers/net/ethernet/intel/e1000e/phy.c
Because same operations and same usage is there in both files.
what say?
>> diff --git a/drivers/net/ethernet/intel/igb/e1000_phy.c b/drivers/net/ethernet/intel/igb/e1000_phy.c
>[]
>> @@ -37,8 +37,7 @@ static s32 igb_set_master_slave_mode(struct e1000_hw *hw);
>> static const u16 e1000_m88_cable_length_table[] = {
>> 0, 50, 80, 110, 140, 140, E1000_CABLE_LENGTH_UNDEFINED };
>> #define M88E1000_CABLE_LENGTH_TABLE_SIZE \
>> - (sizeof(e1000_m88_cable_length_table) / \
>> - sizeof(e1000_m88_cable_length_table[0]))
>> + ARRAY_SIZE(e1000_m88_cable_length_table)
>> ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
next reply other threads:[~2015-06-30 8:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-30 8:01 Maninder Singh [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-06-30 4:55 [PATCH 1/1] igb: Use ARRAY_SIZE instead fo sizeof(a)/sizeof(a[0]) Maninder Singh
2015-06-30 5:12 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1652907052.50321435651311854.JavaMail.weblogic@ep2mlwas04a \
--to=maninder1.s@samsung.com \
--cc=carolyn.wyborny@intel.com \
--cc=donald.c.skidmore@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=joe@perches.com \
--cc=john.ronciak@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.vick@intel.com \
--cc=mitch.a.williams@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pankaj.m@samsung.com \
--cc=shannon.nelson@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).