From: David Howells <dhowells@redhat.com>
To: netdev@vger.kernel.org
Cc: linux-afs@lists.infradead.org,
Jeffrey Altman <jaltman@auristor.com>,
Marc Dionne <marc.dionne@auristor.com>,
dhowells@redhat.com, linux-afs@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: [PATCH net 0/5] rxrpc: Miscellaneous fixes
Date: Sat, 21 May 2022 09:02:58 +0100 [thread overview]
Message-ID: <165312017819.246773.14440495192028707532.stgit@warthog.procyon.org.uk> (raw)
Here are some fixes for AF_RXRPC:
(1) Fix listen() allowing preallocation to overrun the prealloc buffer.
(2) Prevent resending the request if we've seen the reply starting to
arrive.
(3) Fix accidental sharing of ACK state between transmission and
reception.
(4) Ignore ACKs in which ack.previousPacket regresses. This indicates the
highest DATA number so far seen, so should not be seen to go
backwards.
(5) Fix the determination of when to generate an IDLE-type ACK,
simplifying it so that we generate one if we have more than two DATA
packets that aren't hard-acked (consumed) or soft-acked (in the rx
buffer, but could be discarded and re-requested).
The patches are tagged here:
git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git
rxrpc-fixes-20220521
and can also be found on the following branch:
http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-fixes
Tested-by: kafs-testing+fedora34_64checkkafs-build-495@auristor.com
Changes
=======
ver #2)
- Rebased onto net/master
- Dropped the IPv6 checksum patch as it's already upstream.
David
Link: https://lore.kernel.org/r/165306442115.34086.1818959430525328753.stgit@warthog.procyon.org.uk/ # v1
---
David Howells (5):
rxrpc: Fix listen() setting the bar too high for the prealloc rings
rxrpc: Don't try to resend the request if we're receiving the reply
rxrpc: Fix overlapping ACK accounting
rxrpc: Don't let ack.previousPacket regress
rxrpc: Fix decision on when to generate an IDLE ACK
include/trace/events/rxrpc.h | 2 +-
net/rxrpc/ar-internal.h | 13 +++++++------
net/rxrpc/call_event.c | 3 ++-
net/rxrpc/input.c | 31 ++++++++++++++++++++-----------
net/rxrpc/output.c | 20 ++++++++++++--------
net/rxrpc/recvmsg.c | 8 +++-----
net/rxrpc/sysctl.c | 4 ++--
7 files changed, 47 insertions(+), 34 deletions(-)
next reply other threads:[~2022-05-21 8:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-21 8:02 David Howells [this message]
2022-05-21 8:03 ` [PATCH net 1/5] rxrpc: Fix listen() setting the bar too high for the prealloc rings David Howells
2022-05-21 8:03 ` [PATCH net 2/5] rxrpc: Don't try to resend the request if we're receiving the reply David Howells
2022-05-21 8:03 ` [PATCH net 3/5] rxrpc: Fix overlapping ACK accounting David Howells
2022-05-21 8:03 ` [PATCH net 4/5] rxrpc: Don't let ack.previousPacket regress David Howells
2022-05-21 8:03 ` [PATCH net 5/5] rxrpc: Fix decision on when to generate an IDLE ACK David Howells
2022-05-22 20:32 ` [PATCH net 0/5] rxrpc: Miscellaneous fixes David Miller
2022-05-22 20:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=165312017819.246773.14440495192028707532.stgit@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=jaltman@auristor.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.dionne@auristor.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).