From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B74E6C43334 for ; Tue, 7 Jun 2022 06:39:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237117AbiFGGja (ORCPT ); Tue, 7 Jun 2022 02:39:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41018 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237107AbiFGGjT (ORCPT ); Tue, 7 Jun 2022 02:39:19 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C002FAFB23 for ; Mon, 6 Jun 2022 23:39:17 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id q1so33153014ejz.9 for ; Mon, 06 Jun 2022 23:39:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=loges8s8zoV1C9PFiO71uU1qlpSiYfV9MSsL7MBBWRw=; b=LjQdF1tKP1kQSL+husirj9ps8XjdG4g5cybME/kjkMYjlDiT1Cr034Q4FkeoHhhCQd 2ZhUcIiSQvW1S+GqPeYk4whHbq3utWCf6jbt1PH6+T5TS8QQajLKNPNvpIMLgbmr0Vj8 BDsCEOyhF+kuWbcZ4U8yLsUd6iO1oA2Ai+id7lHLfZGmP238HeZEplNoGU6ZIEk374iV ba3Gqcp/j3YLV2cq/ZlwCO/i/R4AvaSapwf6ny+/cuNGb+HLE9Xq3P5qFMLkfoGifyQX t4b8OsGm3Q61enqMs0j3EIblK83BLEi1hwJDiLWmjfFeLOfUq182eejFL38sX+sATHv9 YOcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=loges8s8zoV1C9PFiO71uU1qlpSiYfV9MSsL7MBBWRw=; b=7lnUIJET7WfQ4kc8IRuyfC4x7x8HXFEed/BQE/W4ADZpntlF2oZnt56Uox7PatkH/9 vI/jTDmiMPY1Mow4JqCtqoAfgbC3flNy7fW5ZI0TEuG2vR3tzUmd12DfdBN/KGN8Vwlv tsDyj1fqWZBuVfUnzPm+GXqqfVaPhf8mmgSvT8mwoQQwmuHMSVOwZlpg0vOhQZKIepgR 6Rz2Qc7EX4Uae9CO53zlQUuaGTiAMjlgyncRWwXzC/OSRKzVGl4VXM8uylK9hLMjNp0H 5S+0AVjL8444vJtb6M04BIoqyump5Mr8GpcVgmV48RZim/nkMHc/V8yscF/8vmMtxyDC E8YA== X-Gm-Message-State: AOAM530fHu7AHr96aq/ITt+p7KwXOhan3A9loyFM1MIkgKUr5v/09D5h njbMDabrU2KMNoBNiQB82dwlKw== X-Google-Smtp-Source: ABdhPJwd5sMXWXnHhxyv65OQ/SEnHwE8kGMI0uMl3SQbTKiwqhP+IINZDFnRlE8FgFVg7MdFxzEJmg== X-Received: by 2002:a17:906:c838:b0:711:d49f:687c with SMTP id dd24-20020a170906c83800b00711d49f687cmr6629267ejb.668.1654583956240; Mon, 06 Jun 2022 23:39:16 -0700 (PDT) Received: from localhost.localdomain (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id jo13-20020a170906f6cd00b006febc86b8besm7016888ejb.117.2022.06.06.23.39.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jun 2022 23:39:15 -0700 (PDT) From: Krzysztof Kozlowski To: Sylwester Nawrocki , linux-arm-kernel@lists.infradead.org, Rob Herring , Tomasz Figa , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Krzysztof Kozlowski , Linus Walleij , linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, Alim Akhtar Cc: Chanho Park Subject: Re: (subset) [PATCH v3 1/8] ARM: dts: s3c2410: use local header for pinctrl register values Date: Tue, 7 Jun 2022 08:39:09 +0200 Message-Id: <165458395109.7886.17085666406343091963.b4-ty@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220605160508.134075-2-krzysztof.kozlowski@linaro.org> References: <20220605160508.134075-1-krzysztof.kozlowski@linaro.org> <20220605160508.134075-2-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 5 Jun 2022 18:05:01 +0200, Krzysztof Kozlowski wrote: > The DTS uses hardware register values directly in pin controller pin > configuration. These are not some IDs or other abstraction layer but > raw numbers used in the registers. > > These numbers were previously put in the bindings header to avoid code > duplication and to provide some context meaning (name), but they do not > fit the purpose of bindings. It is also quite confusing to use > constants prefixed with Exynos for other SoC, because there is actually > nothing here in common, except the actual value. > > [...] Applied, thanks! [1/8] ARM: dts: s3c2410: use local header for pinctrl register values https://git.kernel.org/krzk/linux/c/5dba27958273ffc0056795a479550957a134e981 Best regards, -- Krzysztof Kozlowski