From: Kees Cook <keescook@chromium.org>
To: samitolvanen@google.com
Cc: Kees Cook <keescook@chromium.org>,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
ndesaulniers@google.com, nathan@kernel.org, paulmck@kernel.org
Subject: Re: [PATCH] cfi: Fix __cfi_slowpath_diag RCU usage with cpuidle
Date: Mon, 13 Jun 2022 09:26:10 -0700 [thread overview]
Message-ID: <165513756775.2849041.2389986534725002694.b4-ty@chromium.org> (raw)
In-Reply-To: <20220531175910.890307-1-samitolvanen@google.com>
On Tue, 31 May 2022 10:59:10 -0700, Sami Tolvanen wrote:
> RCU_NONIDLE usage during __cfi_slowpath_diag can result in an invalid
> RCU state in the cpuidle code path:
>
> WARNING: CPU: 1 PID: 0 at kernel/rcu/tree.c:613 rcu_eqs_enter+0xe4/0x138
> ...
> Call trace:
> rcu_eqs_enter+0xe4/0x138
> rcu_idle_enter+0xa8/0x100
> cpuidle_enter_state+0x154/0x3a8
> cpuidle_enter+0x3c/0x58
> do_idle.llvm.6590768638138871020+0x1f4/0x2ec
> cpu_startup_entry+0x28/0x2c
> secondary_start_kernel+0x1b8/0x220
> __secondary_switched+0x94/0x98
>
> [...]
Applied to for-next/hardening, thanks!
[1/1] cfi: Fix __cfi_slowpath_diag RCU usage with cpuidle
https://git.kernel.org/kees/c/57cd6d157eb4
--
Kees Cook
prev parent reply other threads:[~2022-06-13 19:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-31 17:59 [PATCH] cfi: Fix __cfi_slowpath_diag RCU usage with cpuidle Sami Tolvanen
2022-05-31 19:33 ` Kees Cook
2022-05-31 20:55 ` Sami Tolvanen
2022-06-13 16:26 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=165513756775.2849041.2389986534725002694.b4-ty@chromium.org \
--to=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=paulmck@kernel.org \
--cc=samitolvanen@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).