From: alexandre.belloni@bootlin.com
To: linux-kernel@vger.kernel.org, mat.jonczyk@o2.pl,
linux-rtc@vger.kernel.org
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
bp@alien8.de, hpa@zytor.com, x86@kernel.org,
dave.hansen@linux.intel.com, a.zummo@towertech.it,
tglx@linutronix.de, mingo@redhat.com
Subject: Re: (subset) [PATCH 1/3] rtc-mc146818-lib: reduce RTC_UIP polling period
Date: Fri, 24 Jun 2022 18:45:11 +0200 [thread overview]
Message-ID: <165608905386.24026.1966178825029089110.b4-ty@bootlin.com> (raw)
In-Reply-To: <20220225215011.861477-2-mat.jonczyk@o2.pl>
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
On Fri, 25 Feb 2022 22:50:09 +0100, Mateusz Jończyk wrote:
> Waiting 1ms every time is not necessary, for example on some AMD boxes
> the RTC_UIP bit is documented as being high for around 270 microseconds
> in some cases [1], which agreed with experiments on an SB710
> southbridge. So 100us seems optimal.
>
> This in preparation for mach_get_cmos_time() refactoring.
> The functions mc146818_get_time() and mach_get_cmos_time() in
> arch/x86/kernel/rtc.c perform the same function and the code is
> duplicated. mach_get_cmos_time() is busy waiting for the RTC_UIP
> bit to clear, so make mc146818_get_time() more similar to it by reducing
> the polling period.
>
> [...]
Applied, thanks!
[1/3] rtc-mc146818-lib: reduce RTC_UIP polling period
commit: 4b94a798e1ca59f4614f5ff6b94fe0c287412b9b
Best regards,
--
Alexandre Belloni <alexandre.belloni@bootlin.com>
next prev parent reply other threads:[~2022-06-24 16:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-25 21:50 [PATCH 0/3] rtc,x86: RTC CMOS refactoring Mateusz Jończyk
2022-02-25 21:50 ` [PATCH 1/3] rtc-mc146818-lib: reduce RTC_UIP polling period Mateusz Jończyk
2022-06-24 16:45 ` alexandre.belloni [this message]
2022-02-25 21:50 ` [PATCH 2/3] x86/rtc: rewrite mach_get_cmos_time Mateusz Jończyk
2022-02-25 21:50 ` [PATCH 3/3] x86/rtc: rename mach_set_rtc_mmss Mateusz Jończyk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=165608905386.24026.1966178825029089110.b4-ty@bootlin.com \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mat.jonczyk@o2.pl \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).