From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AF4FC4338F for ; Tue, 24 Aug 2021 14:39:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 418256127B for ; Tue, 24 Aug 2021 14:39:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237922AbhHXOkA (ORCPT ); Tue, 24 Aug 2021 10:40:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237952AbhHXOj4 (ORCPT ); Tue, 24 Aug 2021 10:39:56 -0400 Received: from mail-il1-x12d.google.com (mail-il1-x12d.google.com [IPv6:2607:f8b0:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF26DC061757 for ; Tue, 24 Aug 2021 07:39:11 -0700 (PDT) Received: by mail-il1-x12d.google.com with SMTP id y3so20771163ilm.6 for ; Tue, 24 Aug 2021 07:39:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=2IqJ6+wvAbcLnvKQ155gzcTZsBKKAVwzZCgEUfXzQEs=; b=fhwKBjlUkEzQ1tfUfRTdEw3lqd6G8BW4YAKswTg+xc0AIlP37LqukucLvMasdVHI5m ogyXVzehWp2MR0gjNxKKCc2H5Mb92rJBFJJhp/KftKGY2QcONwH5YsBIy6VtQ1lUcx71 aaL21wzP7+DLj0X2yI6VNCO/UwtoQiTKtT2Fo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2IqJ6+wvAbcLnvKQ155gzcTZsBKKAVwzZCgEUfXzQEs=; b=ckdMaajAC1qbl96p8mIGV5auxE/AH7mD6T2unDZeaQL5g12DPw6I0yxZC9NonRPRmF gJLtvn3+8Vcgz/Dt8Pu+rM8wMeCZxFW5qUVifbGpMwyPj6iQIDJma4Mdd2eSAf0EIvNS eupraaAVFZOvyeYHl75hBoZOf84W7vWz+UFh3j2OFOGpS9Bh0vKCY6qvDtYt5cCHTvU9 7OBMgJHxQZFI06iev1ZenNJAPulk84nEnyfenh2tOnLfaZ3V6ywCsVGJES/nfeUKzKsI WJowquKNsILrK615QPtMa/rWyDQB4717p+H6xFGPgk2qj4ol8MX5vt4FhCs+XNZWNIwO 2vlw== X-Gm-Message-State: AOAM531j4Lb/iJFG30yF3iHHWWhi4seSSg5gs3w0Lw31Q941nOhiEZQl bSPch7T/YfMNZQkUuaz9SwBwtQ== X-Google-Smtp-Source: ABdhPJy1J9p5J/lGZ1xY7XaEdtQOiIPUOlkwevm7xG2eAMb+HAcWNxtWygrvePnW4mydDbJ1LPGfHQ== X-Received: by 2002:a05:6e02:2199:: with SMTP id j25mr27331659ila.97.1629815951322; Tue, 24 Aug 2021 07:39:11 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id a14sm4908555iol.24.2021.08.24.07.39.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Aug 2021 07:39:10 -0700 (PDT) Subject: Re: [PATCH linux-next] tools:signal: fix boolreturn.cocci warnings To: CGEL , Catalin Marinas Cc: Will Deacon , Shuah Khan , linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Jing Yangyang , Zeal Robot , Shuah Khan References: <20210824065131.60346-1-deng.changcheng@zte.com.cn> From: Shuah Khan Message-ID: <16561a4f-6043-cc5b-7a50-5be1ff10bfa5@linuxfoundation.org> Date: Tue, 24 Aug 2021 08:39:10 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210824065131.60346-1-deng.changcheng@zte.com.cn> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/24/21 12:51 AM, CGEL wrote: > From: Jing Yangyang > > ./tools/testing/selftests/arm64/signal/test_signals_utils.h:112:9-10 > WARNING: return of 0/1 in function 'get_current_context' with > return type bool > > Return statements in functions returning bool should use true/false > instead of 1/0. > > Generated by: scripts/coccinelle/misc/boolreturn.cocci > > Reported-by: Zeal Robot > Signed-off-by: Jing Yangyang > --- > tools/testing/selftests/arm64/signal/test_signals_utils.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/arm64/signal/test_signals_utils.h b/tools/testing/selftests/arm64/signal/test_signals_utils.h > index 6772b5c..66122e6 100644 > --- a/tools/testing/selftests/arm64/signal/test_signals_utils.h > +++ b/tools/testing/selftests/arm64/signal/test_signals_utils.h > @@ -109,7 +109,7 @@ static __always_inline bool get_current_context(struct tdescr *td, > if (seen_already) { > fprintf(stdout, > "Unexpected successful sigreturn detected: live_uc is stale !\n"); > - return 0; > + return false; > } > seen_already = 1; > > We can't accept this patch. The from and Signed-off-by don't match. thanks, -- Shuah