From: patchwork-bot+netdevbpf@kernel.org
To: Wang Hai <wanghai38@huawei.com>
Cc: kuba@kernel.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com,
jiri@resnulli.us, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, brouer@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v2] net/sched: fix netdevice reference leaks in attach_default_qdiscs()
Date: Tue, 30 Aug 2022 13:40:17 +0000 [thread overview]
Message-ID: <166186681757.11746.2553114028017365543.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20220826090055.24424-1-wanghai38@huawei.com>
Hello:
This patch was applied to netdev/net.git (master)
by Paolo Abeni <pabeni@redhat.com>:
On Fri, 26 Aug 2022 17:00:55 +0800 you wrote:
> In attach_default_qdiscs(), if a dev has multiple queues and queue 0 fails
> to attach qdisc because there is no memory in attach_one_default_qdisc().
> Then dev->qdisc will be noop_qdisc by default. But the other queues may be
> able to successfully attach to default qdisc.
>
> In this case, the fallback to noqueue process will be triggered. If the
> original attached qdisc is not released and a new one is directly
> attached, this will cause netdevice reference leaks.
>
> [...]
Here is the summary with links:
- [net,v2] net/sched: fix netdevice reference leaks in attach_default_qdiscs()
https://git.kernel.org/netdev/net/c/f612466ebecb
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2022-08-30 13:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-26 9:00 [PATCH net v2] net/sched: fix netdevice reference leaks in attach_default_qdiscs() Wang Hai
2022-08-30 13:40 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166186681757.11746.2553114028017365543.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wanghai38@huawei.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).