From: "tip-bot2 for Abel Wu" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Abel Wu <wuyun.abel@bytedance.com>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Josh Don <joshdon@google.com>,
Mel Gorman <mgorman@techsingularity.net>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: sched/core] sched/fair: Remove redundant check in select_idle_smt()
Date: Fri, 09 Sep 2022 09:00:31 -0000 [thread overview]
Message-ID: <166271403165.401.12761825338092319966.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20220907112000.1854-2-wuyun.abel@bytedance.com>
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 3e6efe87cd5ccabf0f1d4e3ef25881ca0fd337e7
Gitweb: https://git.kernel.org/tip/3e6efe87cd5ccabf0f1d4e3ef25881ca0fd337e7
Author: Abel Wu <wuyun.abel@bytedance.com>
AuthorDate: Wed, 07 Sep 2022 19:19:56 +08:00
Committer: Peter Zijlstra <peterz@infradead.org>
CommitterDate: Wed, 07 Sep 2022 21:53:46 +02:00
sched/fair: Remove redundant check in select_idle_smt()
If two cpus share LLC cache, then the two cores they belong to
are also in the same LLC domain.
Signed-off-by: Abel Wu <wuyun.abel@bytedance.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Josh Don <joshdon@google.com>
Acked-by: Mel Gorman <mgorman@techsingularity.net>
Link: https://lore.kernel.org/r/20220907112000.1854-2-wuyun.abel@bytedance.com
---
kernel/sched/fair.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index efceb67..9657c7d 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -6350,14 +6350,11 @@ static int select_idle_core(struct task_struct *p, int core, struct cpumask *cpu
/*
* Scan the local SMT mask for idle CPUs.
*/
-static int select_idle_smt(struct task_struct *p, struct sched_domain *sd, int target)
+static int select_idle_smt(struct task_struct *p, int target)
{
int cpu;
- for_each_cpu(cpu, cpu_smt_mask(target)) {
- if (!cpumask_test_cpu(cpu, p->cpus_ptr) ||
- !cpumask_test_cpu(cpu, sched_domain_span(sd)))
- continue;
+ for_each_cpu_and(cpu, cpu_smt_mask(target), p->cpus_ptr) {
if (available_idle_cpu(cpu) || sched_idle_cpu(cpu))
return cpu;
}
@@ -6381,7 +6378,7 @@ static inline int select_idle_core(struct task_struct *p, int core, struct cpuma
return __select_idle_cpu(core, p);
}
-static inline int select_idle_smt(struct task_struct *p, struct sched_domain *sd, int target)
+static inline int select_idle_smt(struct task_struct *p, int target)
{
return -1;
}
@@ -6615,7 +6612,7 @@ static int select_idle_sibling(struct task_struct *p, int prev, int target)
has_idle_core = test_idle_cores(target, false);
if (!has_idle_core && cpus_share_cache(prev, target)) {
- i = select_idle_smt(p, sd, prev);
+ i = select_idle_smt(p, prev);
if ((unsigned int)i < nr_cpumask_bits)
return i;
}
next prev parent reply other threads:[~2022-09-09 9:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 11:19 [PATCH v4 0/5] sched/fair: Minor SIS optimizations Abel Wu
2022-09-07 11:19 ` [PATCH v4 1/5] sched/fair: Remove redundant check in select_idle_smt() Abel Wu
2022-09-09 9:00 ` tip-bot2 for Abel Wu [this message]
2022-09-07 11:19 ` [PATCH v4 2/5] sched/fair: Avoid double search on same cpu Abel Wu
2022-09-09 9:00 ` [tip: sched/core] " tip-bot2 for Abel Wu
2022-09-07 11:19 ` [PATCH v4 3/5] sched/fair: Remove useless check in select_idle_core() Abel Wu
2022-09-09 9:00 ` [tip: sched/core] " tip-bot2 for Abel Wu
2022-09-07 11:19 ` [PATCH v4 4/5] sched/fair: Default to false in test_idle_cores() Abel Wu
2022-09-09 9:00 ` [tip: sched/core] " tip-bot2 for Abel Wu
2022-09-07 11:20 ` [PATCH v4 5/5] sched/fair: Cleanup for SIS_PROP Abel Wu
2022-09-09 9:00 ` [tip: sched/core] " tip-bot2 for Abel Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166271403165.401.12761825338092319966.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=joshdon@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mgorman@techsingularity.net \
--cc=peterz@infradead.org \
--cc=wuyun.abel@bytedance.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).