From: Kartik <kkartik@nvidia.com>
To: <jonathanh@nvidia.com>
Cc: <akhilrajeev@nvidia.com>, <gregkh@linuxfoundation.org>,
<jirislaby@kernel.org>, <kkartik@nvidia.com>,
<ldewangan@nvidia.com>, <linux-kernel@vger.kernel.org>,
<linux-serial@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
<swarren@nvidia.com>, <thierry.reding@gmail.com>
Subject: Re: [PATCH] serial: tegra: read DMA status before terminating
Date: Tue, 18 Oct 2022 19:03:41 +0530 [thread overview]
Message-ID: <1666100021-16513-1-git-send-email-kkartik@nvidia.com> (raw)
In-Reply-To: <5935afbd-ec39-21f8-1585-57a932261271@nvidia.com>
> The change looks fine to me, but on further review of other similar
> drivers I see that they pause first ...
>
> dmaengine_pause(tup->tx_dma_chan);
> dmaengine_tx_status(tup->tx_dma_chan, tup->tx_cookie, &state);
> dmaengine_terminate_all(tup->tx_dma_chan);
>
> This makes sense so that when we calculate the amount of the data
> transferred we get the exact amount. Can we add a pause while we are at it?
>
> Thanks!
> Jon
I agree.. I will include this in v2.
Regards,
Kartik
prev parent reply other threads:[~2022-10-18 13:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 6:25 [PATCH] serial: tegra: read DMA status before terminating Kartik
2022-10-18 6:25 ` Kartik
2022-10-18 6:38 ` Greg KH
2022-10-18 6:55 ` Kartik
2022-10-18 7:02 ` Greg KH
2022-10-18 7:21 ` Kartik
2022-10-18 13:18 ` Jon Hunter
2022-10-18 13:33 ` Kartik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1666100021-16513-1-git-send-email-kkartik@nvidia.com \
--to=kkartik@nvidia.com \
--cc=akhilrajeev@nvidia.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).