From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59881C43217 for ; Wed, 2 Nov 2022 16:52:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231638AbiKBQwS (ORCPT ); Wed, 2 Nov 2022 12:52:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54914 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229551AbiKBQwQ (ORCPT ); Wed, 2 Nov 2022 12:52:16 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A186B51; Wed, 2 Nov 2022 09:52:15 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 286E461A8E; Wed, 2 Nov 2022 16:52:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2E0CEC433C1; Wed, 2 Nov 2022 16:52:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667407934; bh=sXtRjTK2mDtmiAA5R3kBj+6rdwU5KpPOdCfNoWca9qg=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=bm6Ph2CbSZpLId2m08s1AGZXc4Zv+INVO7HhiiZYyEYMffFnQbBawkP61O/kUkbmb ed0G0bsu+zDggK2zemJQ/n6ByOFeJvbapQxpIF+5lm9+TveK9teTFgwD3vrvLRvGRQ AYEQbw6oQNDQHNDGeSsXG33kmrL1NJhXDDDdxkDepZRsR9aqkpi93iyaOx6s7bWPQN Uvl7Pf+zJRGKU7scYv3KOa0k/b1/zbEAqjOsNnqBhi6U4MdAE5HhkuweZ2wTmA4cFS weMe2iCOn+PlPTYIolsTU+KuFj5DpBb6Do36f3ryY/vL5bWcK3RKS0FG3Sx46Uol6q Vpd+qI+w73xrg== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] ath11k (gcc13): synchronize ath11k_mac_he_gi_to_nl80211_he_gi()'s return type From: Kalle Valo In-Reply-To: <20221031114341.10377-1-jirislaby@kernel.org> References: <20221031114341.10377-1-jirislaby@kernel.org> To: "Jiri Slaby (SUSE)" Cc: linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" , Martin Liska , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <166740792692.20386.4779272467939559487.kvalo@kernel.org> Date: Wed, 2 Nov 2022 16:52:11 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "Jiri Slaby (SUSE)" wrote: > ath11k_mac_he_gi_to_nl80211_he_gi() generates a valid warning with gcc-13: > drivers/net/wireless/ath/ath11k/mac.c:321:20: error: conflicting types for 'ath11k_mac_he_gi_to_nl80211_he_gi' due to enum/integer mismatch; have 'enum nl80211_he_gi(u8)' > drivers/net/wireless/ath/ath11k/mac.h:166:5: note: previous declaration of 'ath11k_mac_he_gi_to_nl80211_he_gi' with type 'u32(u8)' > > I.e. the type of the return value ath11k_mac_he_gi_to_nl80211_he_gi() in > the declaration is u32, while the definition spells enum nl80211_he_gi. > Synchronize them to the latter. > > Cc: Martin Liska > Cc: Kalle Valo > Cc: "David S. Miller" > Cc: Eric Dumazet > Cc: Jakub Kicinski > Cc: Paolo Abeni > Cc: ath11k@lists.infradead.org > Cc: linux-wireless@vger.kernel.org > Cc: netdev@vger.kernel.org > Signed-off-by: Jiri Slaby (SUSE) > Reviewed-by: Jeff Johnson > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. dd1c23226945 wifi: ath11k: synchronize ath11k_mac_he_gi_to_nl80211_he_gi()'s return type -- https://patchwork.kernel.org/project/linux-wireless/patch/20221031114341.10377-1-jirislaby@kernel.org/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches