linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH] scsi:iscsi: rename iscsi_set_param to iscsi_if_set_param
  2022-11-22 18:11 [PATCH] scsi:iscsi: rename iscsi_set_param to iscsi_if_set_param Wenchao Hao
@ 2022-11-22 16:55 ` Mike Christie
  2022-11-22 19:53 ` Lee Duncan
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Mike Christie @ 2022-11-22 16:55 UTC (permalink / raw)
  To: Wenchao Hao, Lee Duncan, Chris Leech, James E . J . Bottomley,
	Martin K . Petersen, open-iscsi, linux-scsi
  Cc: linux-kernel, liuzhiqiang26, linfeilong

On 11/22/22 12:11 PM, Wenchao Hao wrote:
> There are two iscsi_set_param() functions individually defined
> in libiscsi.c and scsi_transport_iscsi.c which is confused.
> 
> So rename the one in scsi_transport_iscsi.c to iscsi_if_set_param().
> 
> Signed-off-by: Wenchao Hao <haowenchao@huawei.com>
> ---
>  drivers/scsi/scsi_transport_iscsi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c
> index cd3db9684e52..c3fe5ecfee59 100644
> --- a/drivers/scsi/scsi_transport_iscsi.c
> +++ b/drivers/scsi/scsi_transport_iscsi.c
> @@ -2988,7 +2988,7 @@ iscsi_if_destroy_conn(struct iscsi_transport *transport, struct iscsi_uevent *ev
>  }
>  
>  static int
> -iscsi_set_param(struct iscsi_transport *transport, struct iscsi_uevent *ev)
> +iscsi_if_set_param(struct iscsi_transport *transport, struct iscsi_uevent *ev)
>  {
>  	char *data = (char*)ev + sizeof(*ev);
>  	struct iscsi_cls_conn *conn;
> @@ -3941,7 +3941,7 @@ iscsi_if_recv_msg(struct sk_buff *skb, struct nlmsghdr *nlh, uint32_t *group)
>  			err = -EINVAL;
>  		break;
>  	case ISCSI_UEVENT_SET_PARAM:
> -		err = iscsi_set_param(transport, ev);
> +		err = iscsi_if_set_param(transport, ev);
>  		break;
>  	case ISCSI_UEVENT_CREATE_CONN:
>  	case ISCSI_UEVENT_DESTROY_CONN:

Reviewed-by: Mike Christie <michael.christie@oracle.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] scsi:iscsi: rename iscsi_set_param to iscsi_if_set_param
@ 2022-11-22 18:11 Wenchao Hao
  2022-11-22 16:55 ` Mike Christie
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Wenchao Hao @ 2022-11-22 18:11 UTC (permalink / raw)
  To: Lee Duncan, Chris Leech, Mike Christie, James E . J . Bottomley,
	Martin K . Petersen, open-iscsi, linux-scsi
  Cc: linux-kernel, liuzhiqiang26, linfeilong, Wenchao Hao

There are two iscsi_set_param() functions individually defined
in libiscsi.c and scsi_transport_iscsi.c which is confused.

So rename the one in scsi_transport_iscsi.c to iscsi_if_set_param().

Signed-off-by: Wenchao Hao <haowenchao@huawei.com>
---
 drivers/scsi/scsi_transport_iscsi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c
index cd3db9684e52..c3fe5ecfee59 100644
--- a/drivers/scsi/scsi_transport_iscsi.c
+++ b/drivers/scsi/scsi_transport_iscsi.c
@@ -2988,7 +2988,7 @@ iscsi_if_destroy_conn(struct iscsi_transport *transport, struct iscsi_uevent *ev
 }
 
 static int
-iscsi_set_param(struct iscsi_transport *transport, struct iscsi_uevent *ev)
+iscsi_if_set_param(struct iscsi_transport *transport, struct iscsi_uevent *ev)
 {
 	char *data = (char*)ev + sizeof(*ev);
 	struct iscsi_cls_conn *conn;
@@ -3941,7 +3941,7 @@ iscsi_if_recv_msg(struct sk_buff *skb, struct nlmsghdr *nlh, uint32_t *group)
 			err = -EINVAL;
 		break;
 	case ISCSI_UEVENT_SET_PARAM:
-		err = iscsi_set_param(transport, ev);
+		err = iscsi_if_set_param(transport, ev);
 		break;
 	case ISCSI_UEVENT_CREATE_CONN:
 	case ISCSI_UEVENT_DESTROY_CONN:
-- 
2.35.3


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] scsi:iscsi: rename iscsi_set_param to iscsi_if_set_param
  2022-11-22 18:11 [PATCH] scsi:iscsi: rename iscsi_set_param to iscsi_if_set_param Wenchao Hao
  2022-11-22 16:55 ` Mike Christie
@ 2022-11-22 19:53 ` Lee Duncan
  2022-11-24  3:27 ` Martin K. Petersen
  2022-12-01  3:45 ` Martin K. Petersen
  3 siblings, 0 replies; 5+ messages in thread
From: Lee Duncan @ 2022-11-22 19:53 UTC (permalink / raw)
  To: Wenchao Hao, Chris Leech, Mike Christie, James E . J . Bottomley,
	Martin K . Petersen, open-iscsi, linux-scsi
  Cc: linux-kernel, liuzhiqiang26, linfeilong

On 11/22/22 10:11, Wenchao Hao wrote:
> There are two iscsi_set_param() functions individually defined
> in libiscsi.c and scsi_transport_iscsi.c which is confused.
> 
> So rename the one in scsi_transport_iscsi.c to iscsi_if_set_param().
> 
> Signed-off-by: Wenchao Hao <haowenchao@huawei.com>
> ---
>   drivers/scsi/scsi_transport_iscsi.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c
> index cd3db9684e52..c3fe5ecfee59 100644
> --- a/drivers/scsi/scsi_transport_iscsi.c
> +++ b/drivers/scsi/scsi_transport_iscsi.c
> @@ -2988,7 +2988,7 @@ iscsi_if_destroy_conn(struct iscsi_transport *transport, struct iscsi_uevent *ev
>   }
>   
>   static int
> -iscsi_set_param(struct iscsi_transport *transport, struct iscsi_uevent *ev)
> +iscsi_if_set_param(struct iscsi_transport *transport, struct iscsi_uevent *ev)
>   {
>   	char *data = (char*)ev + sizeof(*ev);
>   	struct iscsi_cls_conn *conn;
> @@ -3941,7 +3941,7 @@ iscsi_if_recv_msg(struct sk_buff *skb, struct nlmsghdr *nlh, uint32_t *group)
>   			err = -EINVAL;
>   		break;
>   	case ISCSI_UEVENT_SET_PARAM:
> -		err = iscsi_set_param(transport, ev);
> +		err = iscsi_if_set_param(transport, ev);
>   		break;
>   	case ISCSI_UEVENT_CREATE_CONN:
>   	case ISCSI_UEVENT_DESTROY_CONN:

Reviewed-by: Lee Duncan <lduncan@suse.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] scsi:iscsi: rename iscsi_set_param to iscsi_if_set_param
  2022-11-22 18:11 [PATCH] scsi:iscsi: rename iscsi_set_param to iscsi_if_set_param Wenchao Hao
  2022-11-22 16:55 ` Mike Christie
  2022-11-22 19:53 ` Lee Duncan
@ 2022-11-24  3:27 ` Martin K. Petersen
  2022-12-01  3:45 ` Martin K. Petersen
  3 siblings, 0 replies; 5+ messages in thread
From: Martin K. Petersen @ 2022-11-24  3:27 UTC (permalink / raw)
  To: Wenchao Hao
  Cc: Lee Duncan, Chris Leech, Mike Christie, James E . J . Bottomley,
	Martin K . Petersen, open-iscsi, linux-scsi, linux-kernel,
	liuzhiqiang26, linfeilong


Wenchao,

> There are two iscsi_set_param() functions individually defined in
> libiscsi.c and scsi_transport_iscsi.c which is confused.

Applied to 6.2/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] scsi:iscsi: rename iscsi_set_param to iscsi_if_set_param
  2022-11-22 18:11 [PATCH] scsi:iscsi: rename iscsi_set_param to iscsi_if_set_param Wenchao Hao
                   ` (2 preceding siblings ...)
  2022-11-24  3:27 ` Martin K. Petersen
@ 2022-12-01  3:45 ` Martin K. Petersen
  3 siblings, 0 replies; 5+ messages in thread
From: Martin K. Petersen @ 2022-12-01  3:45 UTC (permalink / raw)
  To: Mike Christie, James E . J . Bottomley, Chris Leech, linux-scsi,
	Wenchao Hao, Lee Duncan, open-iscsi
  Cc: Martin K . Petersen, linux-kernel, linfeilong, liuzhiqiang26

On Tue, 22 Nov 2022 18:11:05 +0000, Wenchao Hao wrote:

> There are two iscsi_set_param() functions individually defined
> in libiscsi.c and scsi_transport_iscsi.c which is confused.
> 
> So rename the one in scsi_transport_iscsi.c to iscsi_if_set_param().
> 
> 

Applied to 6.2/scsi-queue, thanks!

[1/1] scsi:iscsi: rename iscsi_set_param to iscsi_if_set_param
      https://git.kernel.org/mkp/scsi/c/0c26a2d7c980

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-12-01  3:47 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-22 18:11 [PATCH] scsi:iscsi: rename iscsi_set_param to iscsi_if_set_param Wenchao Hao
2022-11-22 16:55 ` Mike Christie
2022-11-22 19:53 ` Lee Duncan
2022-11-24  3:27 ` Martin K. Petersen
2022-12-01  3:45 ` Martin K. Petersen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).