From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
Chen Zhongjin <chenzhongjin@huawei.com>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
jejb@linux.ibm.com, bprakash@broadcom.com,
robert.w.love@intel.com, James.Bottomley@suse.de, hare@suse.de,
yi.zou@intel.com
Subject: Re: [PATCH] scsi: fcoe: Fix transport not deattached when fcoe_if_init() fails
Date: Thu, 1 Dec 2022 03:45:05 +0000 [thread overview]
Message-ID: <166986602287.2101055.16563015716609057451.b4-ty@oracle.com> (raw)
In-Reply-To: <20221115092442.133088-1-chenzhongjin@huawei.com>
On Tue, 15 Nov 2022 17:24:42 +0800, Chen Zhongjin wrote:
> fcoe_init() calls fcoe_transport_attach(&fcoe_sw_transport), but when
> fcoe_if_init() fails, &fcoe_sw_transport is not detached and leave freed
> &fcoe_sw_transport on list fcoe_transports, which causes panic when
> reinserting module.
>
> BUG: unable to handle page fault for address: fffffbfff82e2213
> RIP: 0010:fcoe_transport_attach+0xe1/0x230 [libfcoe]
> Call Trace:
> <TASK>
> do_one_initcall+0xd0/0x4e0
> load_module+0x5eee/0x7210
> ...
>
> [...]
Applied to 6.2/scsi-queue, thanks!
[1/1] scsi: fcoe: Fix transport not deattached when fcoe_if_init() fails
https://git.kernel.org/mkp/scsi/c/4155658cee39
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2022-12-01 3:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 9:24 [PATCH] scsi: fcoe: Fix transport not deattached when fcoe_if_init() fails Chen Zhongjin
2022-11-26 0:21 ` Martin K. Petersen
2022-12-01 3:45 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166986602287.2101055.16563015716609057451.b4-ty@oracle.com \
--to=martin.petersen@oracle.com \
--cc=James.Bottomley@suse.de \
--cc=bprakash@broadcom.com \
--cc=chenzhongjin@huawei.com \
--cc=hare@suse.de \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=robert.w.love@intel.com \
--cc=yi.zou@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).