* [PATCHv2] scsi: Fix get_user() in call sg_scsi_ioctl()
@ 2022-11-17 23:23 Kirill A. Shutemov
2022-11-26 3:14 ` Martin K. Petersen
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Kirill A. Shutemov @ 2022-11-17 23:23 UTC (permalink / raw)
To: jejb, martin.petersen, linux-scsi
Cc: dave.hansen, David.Laight, linux-kernel, x86, Kirill A. Shutemov
get_user() expects the pointer to be pointer-to-simple-variable type,
but sic->data is array of 'unsigned char'. It violates get_user()
contracts.
Explicitly take pointer to the first element of the array. It matches
current behaviour.
This is preparation for fixing sparse warnings caused by Linear Address
Masking patchset.
Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
---
drivers/scsi/scsi_ioctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/scsi_ioctl.c b/drivers/scsi/scsi_ioctl.c
index 2d20da55fb64..fdd47565a311 100644
--- a/drivers/scsi/scsi_ioctl.c
+++ b/drivers/scsi/scsi_ioctl.c
@@ -519,7 +519,7 @@ static int sg_scsi_ioctl(struct request_queue *q, fmode_t mode,
return -EFAULT;
if (in_len > PAGE_SIZE || out_len > PAGE_SIZE)
return -EINVAL;
- if (get_user(opcode, sic->data))
+ if (get_user(opcode, &sic->data[0]))
return -EFAULT;
bytes = max(in_len, out_len);
--
2.38.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCHv2] scsi: Fix get_user() in call sg_scsi_ioctl()
2022-11-17 23:23 [PATCHv2] scsi: Fix get_user() in call sg_scsi_ioctl() Kirill A. Shutemov
@ 2022-11-26 3:14 ` Martin K. Petersen
2022-11-28 9:06 ` Kirill A. Shutemov
2022-12-01 3:45 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2022-11-26 3:14 UTC (permalink / raw)
To: Kirill A. Shutemov
Cc: jejb, martin.petersen, linux-scsi, dave.hansen, David.Laight,
linux-kernel, x86
Kirill,
> get_user() expects the pointer to be pointer-to-simple-variable type,
> but sic->data is array of 'unsigned char'. It violates get_user()
> contracts.
Applied to 6.2/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCHv2] scsi: Fix get_user() in call sg_scsi_ioctl()
2022-11-17 23:23 [PATCHv2] scsi: Fix get_user() in call sg_scsi_ioctl() Kirill A. Shutemov
2022-11-26 3:14 ` Martin K. Petersen
@ 2022-11-28 9:06 ` Kirill A. Shutemov
2022-12-01 3:45 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Kirill A. Shutemov @ 2022-11-28 9:06 UTC (permalink / raw)
To: Kirill A. Shutemov
Cc: jejb, martin.petersen, linux-scsi, dave.hansen, David.Laight,
linux-kernel, x86
On Fri, Nov 18, 2022 at 02:23:04AM +0300, Kirill A. Shutemov wrote:
> get_user() expects the pointer to be pointer-to-simple-variable type,
> but sic->data is array of 'unsigned char'. It violates get_user()
> contracts.
>
> Explicitly take pointer to the first element of the array. It matches
> current behaviour.
>
> This is preparation for fixing sparse warnings caused by Linear Address
> Masking patchset.
>
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
> Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
James, Martin, ping?
It prevents a fix for sparse warnings from applying.
> ---
> drivers/scsi/scsi_ioctl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/scsi_ioctl.c b/drivers/scsi/scsi_ioctl.c
> index 2d20da55fb64..fdd47565a311 100644
> --- a/drivers/scsi/scsi_ioctl.c
> +++ b/drivers/scsi/scsi_ioctl.c
> @@ -519,7 +519,7 @@ static int sg_scsi_ioctl(struct request_queue *q, fmode_t mode,
> return -EFAULT;
> if (in_len > PAGE_SIZE || out_len > PAGE_SIZE)
> return -EINVAL;
> - if (get_user(opcode, sic->data))
> + if (get_user(opcode, &sic->data[0]))
> return -EFAULT;
>
> bytes = max(in_len, out_len);
> --
> 2.38.0
>
--
Kiryl Shutsemau / Kirill A. Shutemov
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCHv2] scsi: Fix get_user() in call sg_scsi_ioctl()
2022-11-17 23:23 [PATCHv2] scsi: Fix get_user() in call sg_scsi_ioctl() Kirill A. Shutemov
2022-11-26 3:14 ` Martin K. Petersen
2022-11-28 9:06 ` Kirill A. Shutemov
@ 2022-12-01 3:45 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2022-12-01 3:45 UTC (permalink / raw)
To: Kirill A. Shutemov, linux-scsi, jejb
Cc: Martin K . Petersen, x86, linux-kernel, David.Laight, dave.hansen
On Fri, 18 Nov 2022 02:23:04 +0300, Kirill A. Shutemov wrote:
> get_user() expects the pointer to be pointer-to-simple-variable type,
> but sic->data is array of 'unsigned char'. It violates get_user()
> contracts.
>
> Explicitly take pointer to the first element of the array. It matches
> current behaviour.
>
> [...]
Applied to 6.2/scsi-queue, thanks!
[1/1] scsi: Fix get_user() in call sg_scsi_ioctl()
https://git.kernel.org/mkp/scsi/c/4e80eef45ad7
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-12-01 3:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-17 23:23 [PATCHv2] scsi: Fix get_user() in call sg_scsi_ioctl() Kirill A. Shutemov
2022-11-26 3:14 ` Martin K. Petersen
2022-11-28 9:06 ` Kirill A. Shutemov
2022-12-01 3:45 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).