From: Rob Herring <robh@kernel.org>
To: Eddie James <eajames@linux.ibm.com>
Cc: linux-trace-kernel@vger.kernel.org, jk@ozlabs.org,
joel@jms.id.au, rostedt@goodmis.org, mhiramat@kernel.org,
alistair@popple.id.au, robh+dt@kernel.org,
linux-kernel@vger.kernel.org, andrew@aj.id.au,
linux-fsi@lists.ozlabs.org, krzysztof.kozlowski+dt@linaro.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: fsi: Document the IBM I2C Responder virtual FSI master
Date: Wed, 25 Jan 2023 20:54:29 -0600 [thread overview]
Message-ID: <167470157981.71746.7854932259135609750.robh@kernel.org> (raw)
In-Reply-To: <20230125225416.4074040-2-eajames@linux.ibm.com>
On Wed, 25 Jan 2023 16:54:15 -0600, Eddie James wrote:
> The I2C Responder translates I2C commands to CFAM or SCOM operations,
> effectively implementing an FSI master.
>
> Signed-off-by: Eddie James <eajames@linux.ibm.com>
> ---
> .../bindings/fsi/ibm,i2cr-fsi-master.yaml | 41 +++++++++++++++++++
> 1 file changed, 41 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/fsi/ibm,i2cr-fsi-master.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
./Documentation/devicetree/bindings/fsi/ibm,i2cr-fsi-master.yaml:32:2: [warning] wrong indentation: expected 2 but found 1 (indentation)
dtschema/dtc warnings/errors:
./Documentation/devicetree/bindings/fsi/ibm,i2cr-fsi-master.yaml: $id: relative path/filename doesn't match actual path or filename
expected: http://devicetree.org/schemas/fsi/ibm,i2cr-fsi-master.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230125225416.4074040-2-eajames@linux.ibm.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2023-01-26 2:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 22:54 [PATCH v2 0/2] fsi: Add IBM I2C Responder virtual FSI master Eddie James
2023-01-25 22:54 ` [PATCH v2 1/2] dt-bindings: fsi: Document the " Eddie James
2023-01-26 2:54 ` Rob Herring [this message]
2023-01-25 22:54 ` [PATCH v2 2/2] fsi: Add " Eddie James
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167470157981.71746.7854932259135609750.robh@kernel.org \
--to=robh@kernel.org \
--cc=alistair@popple.id.au \
--cc=andrew@aj.id.au \
--cc=devicetree@vger.kernel.org \
--cc=eajames@linux.ibm.com \
--cc=jk@ozlabs.org \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-fsi@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=robh+dt@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).