From: "NeilBrown" <neilb@suse.de>
To: "Paul Cercueil" <paul@crapouillou.net>
Cc: "H. Nikolaus Schaller" <hns@goldelico.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
周琰杰 <zhouyanjie@wanyeetech.com>,
linux-mips@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, letux-kernel@openphoenux.org
Subject: Re: [PATCH] MIPS: DTS: CI20: fix otg power gpio
Date: Mon, 30 Jan 2023 15:57:53 +1100 [thread overview]
Message-ID: <167505467359.23017.2124580706077477317@noble.neil.brown.name> (raw)
In-Reply-To: <b7745c417d5ac46efa273f1fc45217bb6254ea4f.camel@crapouillou.net>
On Mon, 30 Jan 2023, Paul Cercueil wrote:
> Le dimanche 29 janvier 2023 à 18:48 +0100, H. Nikolaus Schaller a
> écrit :
> > According to schematics it is PF15 and not PF14 (MIC_SW_EN).
> > Seems as if it was hidden and not noticed during testing since
> > there is no sound DT node.
> >
> > Fixes: 158c774d3c64 ("MIPS: Ingenic: Add missing nodes for Ingenic
> > SoCs and boards.")
> > Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
>
> I missed it, but every time you have a Fixes: tag, you also need to add
> below:
> Cc: stable@vger.kernel.org
I don't think you do any more. The stable team grabs anything that
looks even vaguely like a fix and applies it. Having a valid Fixes tag
is enough for the stable team to take interest.
NeilBrown
>
> unless the bug you fix is in one of the RCs (and not in a released
> kernel).
>
> I think you should send a V2 with this tag (and my ACK).
>
> Cheers,
> -Paul
>
> > ---
> > arch/mips/boot/dts/ingenic/ci20.dts | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/mips/boot/dts/ingenic/ci20.dts
> > b/arch/mips/boot/dts/ingenic/ci20.dts
> > index 9819abb2465dd..a276488c0f752 100644
> > --- a/arch/mips/boot/dts/ingenic/ci20.dts
> > +++ b/arch/mips/boot/dts/ingenic/ci20.dts
> > @@ -115,7 +115,7 @@ otg_power: fixedregulator@2 {
> > regulator-min-microvolt = <5000000>;
> > regulator-max-microvolt = <5000000>;
> >
> > - gpio = <&gpf 14 GPIO_ACTIVE_LOW>;
> > + gpio = <&gpf 15 GPIO_ACTIVE_LOW>;
> > enable-active-high;
> > };
> > };
>
>
prev parent reply other threads:[~2023-01-30 4:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-29 17:48 [PATCH] MIPS: DTS: CI20: fix otg power gpio H. Nikolaus Schaller
2023-01-29 18:08 ` Paul Cercueil
2023-01-29 18:18 ` H. Nikolaus Schaller
2023-01-29 18:47 ` Paul Cercueil
2023-01-29 18:56 ` H. Nikolaus Schaller
2023-01-30 4:57 ` NeilBrown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167505467359.23017.2124580706077477317@noble.neil.brown.name \
--to=neilb@suse.de \
--cc=devicetree@vger.kernel.org \
--cc=hns@goldelico.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=letux-kernel@openphoenux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=paul@crapouillou.net \
--cc=robh+dt@kernel.org \
--cc=tsbogend@alpha.franken.de \
--cc=zhouyanjie@wanyeetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).