From: Joe Perches <golf@perches.com>
To: Daniel Thompson <daniel.thompson@linaro.org>, zhe.he@windriver.com
Cc: jason.wessel@windriver.com, gregkh@linuxfoundation.org,
jslaby@suse.com, kgdb-bugreport@lists.sourceforge.net,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] kgdboc: Change printk to the right fashion
Date: Tue, 14 Aug 2018 07:04:11 -0700 [thread overview]
Message-ID: <1678613360b7aebbf1ab42dd89139cb666ee8cd9.camel@perches.com> (raw)
In-Reply-To: <20180814133536.bfpygzwnmlqfsee5@holly.lan>
On Tue, 2018-08-14 at 14:35 +0100, Daniel Thompson wrote:
> On Tue, Aug 14, 2018 at 08:46:01PM +0800, zhe.he@windriver.com wrote:
> > From: He Zhe <zhe.he@windriver.com>
> >
> > pr_* is preferred according to scripts/checkpatch.pl.
[]
> > diff --git a/drivers/tty/serial/kgdboc.c b/drivers/tty/serial/kgdboc.c
[]
> > @@ -136,7 +136,7 @@ static int kgdboc_option_setup(char *opt)
> > }
> >
> > if (strlen(opt) >= MAX_CONFIG_LEN) {
> > - printk(KERN_ERR "kgdboc: config string too long\n");
> > + pr_err("kgdboc: config string too long\n");
>
> Looks like you should remove the tags from pr_err and use pr_fmt(fmt) to
> put tags on the messages:
>
> #define pr_fmt(fmt) "kgdboc: " fmt
True and it's probably better to use:
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
next prev parent reply other threads:[~2018-08-14 14:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-14 12:46 [PATCH v2 1/2] kgdboc: Passing ekgdboc to command line causes panic zhe.he
2018-08-14 12:46 ` [PATCH v2 2/2] kgdboc: Change printk to the right fashion zhe.he
2018-08-14 13:35 ` Daniel Thompson
2018-08-14 14:04 ` Joe Perches [this message]
2018-08-14 14:41 ` Daniel Thompson
2018-08-14 15:39 ` He Zhe
2018-08-14 13:26 ` [PATCH v2 1/2] kgdboc: Passing ekgdboc to command line causes panic Daniel Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1678613360b7aebbf1ab42dd89139cb666ee8cd9.camel@perches.com \
--to=golf@perches.com \
--cc=daniel.thompson@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=jason.wessel@windriver.com \
--cc=jslaby@suse.com \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=zhe.he@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).