From: Jens Axboe <axboe@fb.com>
To: Ming Lei <tom.leiming@gmail.com>, <linux-kernel@vger.kernel.org>
Cc: <linux-block@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>,
"Christoph Hellwig" <hch@infradead.org>,
Adrian Hunter <adrian.hunter@intel.com>, Coly Li <colyli@suse.de>,
"open list:DEVICE-MAPPER (LVM)" <dm-devel@redhat.com>,
"open list:DRBD DRIVER" <drbd-dev@lists.linbit.com>,
Eric Wheeler <git@linux.ewheeler.net>,
Guoqing Jiang <gqjiang@suse.com>, Hannes Reinecke <hare@suse.com>,
Jiri Kosina <jkosina@suse.cz>,
Johannes Thumshirn <jthumshirn@suse.de>,
Keith Busch <keith.busch@intel.com>,
Kent Overstreet <kent.overstreet@gmail.com>,
"open list:BCACHE (BLOCK LAYER CACHE)"
<linux-bcache@vger.kernel.org>,
"open list:NVM EXPRESS TARGET DRIVER"
<linux-nvme@lists.infradead.org>,
"open list:SOFTWARE RAID (Multiple Disks) SUPPORT"
<linux-raid@vger.kernel.org>,
"open list:TARGET SUBSYSTEM" <linux-scsi@vger.kernel.org>,
"open list:LogFS" <logfs@logfs.org>,
"Mike Christie" <mchristi@redhat.com>,
Mike Snitzer <snitzer@redhat.com>,
"Rasmus Villemoes" <linux@rasmusvillemoes.dk>,
"open list:TARGET SUBSYSTEM" <target-devel@vger.kernel.org>,
Yijing Wang <wangyijing@huawei.com>,
"Zheng Liu" <wenqing.lz@taobao.com>
Subject: Re: [PATCH 00/12] block: cleanup direct access to bvec table
Date: Tue, 22 Nov 2016 08:53:00 -0700 [thread overview]
Message-ID: <167c2511-349f-a8e6-17d1-f7ce438b2f14@fb.com> (raw)
In-Reply-To: <1478865957-25252-1-git-send-email-tom.leiming@gmail.com>
On 11/11/2016 05:05 AM, Ming Lei wrote:
> Hi,
>
> This patchset cleans up direct access to bvec table.
>
> The 1st patch passes bvec table to bio_init(), so that
> direct access to bvec table in bio initialization is avoided.
>
> For other patches, most of them uses bio_add_page()
> to replace hardcode style of adding page to bvec,
> and others avoids to access bio->bi_vcnt.
>
> The most special one is to use bvec iterator helpers
> to implement .get_page/.next_page for dm-io.c
>
> One big motivation is to prepare for supporting multipage
> bvec, but this patchset is one good cleanup too even not
> for that purpose.
I've added the series, except 6-8, the dm parts. I updated some of the
descriptions/subjects to read a little better.
--
Jens Axboe
prev parent reply other threads:[~2016-11-22 15:54 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-11 12:05 [PATCH 00/12] block: cleanup direct access to bvec table Ming Lei
2016-11-11 12:05 ` [PATCH 01/12] block: bio: pass bvec table to bio_init() Ming Lei
2016-11-12 17:59 ` Christoph Hellwig
2016-11-11 12:05 ` [PATCH 02/12] block: drbd: remove impossible failure handling Ming Lei
2016-11-11 12:05 ` [PATCH 03/12] block: floppy: use bio_add_page() Ming Lei
2016-11-12 18:00 ` Christoph Hellwig
2016-11-11 12:05 ` [PATCH 04/12] target: avoid to access .bi_vcnt directly Ming Lei
2016-11-12 21:37 ` Sagi Grimberg
2016-11-11 12:05 ` [PATCH 05/12] bcache: debug: avoid to access .bi_io_vec directly Ming Lei
2016-11-22 7:30 ` Christoph Hellwig
2016-11-11 12:05 ` [PATCH 06/12] dm: crypt: use bio_add_page() Ming Lei
2016-11-21 14:49 ` Mike Snitzer
2016-11-11 12:05 ` [PATCH 07/12] dm: use bvec iterator helpers to implement .get_page and .next_page Ming Lei
2016-11-15 1:01 ` Ming Lei
2016-11-15 18:55 ` Christoph Hellwig
2016-11-15 18:57 ` Mike Snitzer
2016-11-21 14:49 ` Mike Snitzer
2016-11-22 0:26 ` Ming Lei
2016-11-22 7:28 ` Christoph Hellwig
2016-11-11 12:05 ` [PATCH 08/12] dm: dm.c: replace 'bio->bi_vcnt == 1' with !bio_multiple_segments Ming Lei
2016-11-15 1:03 ` Ming Lei
2016-11-21 14:50 ` Mike Snitzer
2016-11-11 12:05 ` [PATCH 09/12] fs: logfs: convert to bio_add_page() in sync_request() Ming Lei
2016-11-11 12:05 ` [PATCH 10/12] fs: logfs: use bio_add_page() in __bdev_writeseg() Ming Lei
2016-11-11 12:05 ` [PATCH 11/12] fs: logfs: use bio_add_page() in do_erase() Ming Lei
2016-11-11 12:05 ` [PATCH 12/12] fs: logfs: remove unnecesary check Ming Lei
2016-11-22 15:53 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167c2511-349f-a8e6-17d1-f7ce438b2f14@fb.com \
--to=axboe@fb.com \
--cc=adrian.hunter@intel.com \
--cc=colyli@suse.de \
--cc=dm-devel@redhat.com \
--cc=drbd-dev@lists.linbit.com \
--cc=git@linux.ewheeler.net \
--cc=gqjiang@suse.com \
--cc=hare@suse.com \
--cc=hch@infradead.org \
--cc=jkosina@suse.cz \
--cc=jthumshirn@suse.de \
--cc=keith.busch@intel.com \
--cc=kent.overstreet@gmail.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=logfs@logfs.org \
--cc=mchristi@redhat.com \
--cc=snitzer@redhat.com \
--cc=target-devel@vger.kernel.org \
--cc=tom.leiming@gmail.com \
--cc=wangyijing@huawei.com \
--cc=wenqing.lz@taobao.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).