From: "Heiko Stübner" <heiko@sntech.de>
To: Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Demetris Ierokipides <ierokipides.dem@gmail.com>
Cc: Demetris Ierokipides <ierokipides.dem@gmail.com>
Subject: Re: [PATCH 2/2] ARM: dts: rockchip: add extra cpu opp points to rk3288-miqi
Date: Sat, 09 Jan 2021 14:40:55 +0100 [thread overview]
Message-ID: <1680769.VLH7GnMWUR@diego> (raw)
In-Reply-To: <20210108151036.36434-3-ierokipides.dem@gmail.com>
Hi Demetris,
Am Freitag, 8. Januar 2021, 16:10:36 CET schrieb Demetris Ierokipides:
> Add extra 1.7GHz and 1.8GHz opp points to the MiQi device-tree to improve
> performance.
>
> Signed-off-by: Demetris Ierokipides <ierokipides.dem@gmail.com>
> ---
> arch/arm/boot/dts/rk3288-miqi.dts | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/arch/arm/boot/dts/rk3288-miqi.dts b/arch/arm/boot/dts/rk3288-miqi.dts
> index 713f55e143c6..1b48855db6ff 100644
> --- a/arch/arm/boot/dts/rk3288-miqi.dts
> +++ b/arch/arm/boot/dts/rk3288-miqi.dts
> @@ -96,6 +96,18 @@ &cpu3 {
> cpu-supply = <&vdd_cpu>;
> };
>
> +&cpu_opp_table {
> + opp-1704000000 {
> + opp-hz = /bits/ 64 <1704000000>;
> + opp-microvolt = <1350000>;
> + };
> +
> + opp-1800000000 {
> + opp-hz = /bits/ 64 <1800000000>;
> + opp-microvolt = <1350000>;
> + };
> +};
> +
sorry, but no .
The OPPs in the mainline kernel match the specifications released by the
soc vendor. Going outside these specs _may_ affect things like stability
on some boards or in general simply the lifetime of the chip itself.
So yes, while boards may generally work with these higher frequencies
I don't think this should be the default coming from the mainline kernel.
If board-owners feel the need to exceed the specs they can still modify
the dts, but we shouldn't force this decision on everyone.
Heiko
next prev parent reply other threads:[~2021-01-09 13:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-08 15:10 [PATCH 0/2] ARM: dts: rockchip: minor tweaks for rk3288-miqi.This series adds a missing mali GPU node and two additional CPU opp points Demetris Ierokipides
2021-01-08 15:10 ` [PATCH 1/2] ARM: dts: rockchip: add gpu node to rk3288-miqi Demetris Ierokipides
2021-01-08 15:10 ` [PATCH 2/2] ARM: dts: rockchip: add extra cpu opp points " Demetris Ierokipides
2021-01-09 13:40 ` Heiko Stübner [this message]
2021-01-09 15:39 ` (subset) [PATCH 0/2] ARM: dts: rockchip: minor tweaks for rk3288-miqi.This series adds a missing mali GPU node and two additional CPU opp points Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1680769.VLH7GnMWUR@diego \
--to=heiko@sntech.de \
--cc=devicetree@vger.kernel.org \
--cc=ierokipides.dem@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).