From: "Theodore Ts'o" <tytso@mit.edu>
To: adilger.kernel@dilger.ca, Kemeng Shi <shikemeng@huaweicloud.com>
Cc: "Theodore Ts'o" <tytso@mit.edu>,
s.l-h@gmx.de, linux-ext4@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert "ext4: remove unnecessary check in ext4_bg_num_gdb_nometa"
Date: Thu, 15 Jun 2023 10:59:56 -0400 [thread overview]
Message-ID: <168683994078.282246.12341856291517677835.b4-ty@mit.edu> (raw)
In-Reply-To: <20230613225025.3859522-1-shikemeng@huaweicloud.com>
On Wed, 14 Jun 2023 06:50:25 +0800, Kemeng Shi wrote:
> This reverts commit ad3f09be6cfe332be8ff46c78e6ec0f8839107aa.
>
> The reverted commit was intended to simpfy the code to get group
> descriptor block number in non-meta block group by assuming
> s_gdb_count is block number used for all non-meta block group descriptors.
> However s_gdb_count is block number used for all meta *and* non-meta
> group descriptors. So s_gdb_group will be > actual group descriptor block
> number used for all non-meta block group which should be "total non-meta
> block group" / "group descriptors per block", e.g. s_first_meta_bg.
>
> [...]
Applied, thanks!
[1/1] Revert "ext4: remove unnecessary check in ext4_bg_num_gdb_nometa"
commit: 19482792113fa1dc419f9bc7b04b9dbdaa5256fd
Best regards,
--
Theodore Ts'o <tytso@mit.edu>
prev parent reply other threads:[~2023-06-15 15:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-13 22:50 [PATCH] Revert "ext4: remove unnecessary check in ext4_bg_num_gdb_nometa" Kemeng Shi
2023-06-15 14:59 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168683994078.282246.12341856291517677835.b4-ty@mit.edu \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=s.l-h@gmx.de \
--cc=shikemeng@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).