From: "Theodore Ts'o" <tytso@mit.edu>
To: Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
"Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc: "Theodore Ts'o" <tytso@mit.edu>,
syzbot+4acc7d910e617b360859@syzkaller.appspotmail.com
Subject: Re: [PATCH] ext4: Drop the call to ext4_error() from ext4_get_group_info()
Date: Thu, 15 Jun 2023 10:59:54 -0400 [thread overview]
Message-ID: <168683994079.282246.8360074850989025705.b4-ty@mit.edu> (raw)
In-Reply-To: <20230614100446.14337-1-fmdefrancesco@gmail.com>
On Wed, 14 Jun 2023 12:02:55 +0200, Fabio M. De Francesco wrote:
> A recent patch added a call to ext4_error() which is problematic since
> some callers of the ext4_get_group_info() function may be holding a
> spinlock, whereas ext4_error() must never be called in atomic context.
>
> This triggered a report from Syzbot: "BUG: sleeping function called from
> invalid context in ext4_update_super" (see the link below).
>
> [...]
Applied, thanks!
[1/1] ext4: Drop the call to ext4_error() from ext4_get_group_info()
commit: f451fd97dd2b78f286379203a47d9d295c467255
Best regards,
--
Theodore Ts'o <tytso@mit.edu>
prev parent reply other threads:[~2023-06-15 15:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 10:02 [PATCH] ext4: Drop the call to ext4_error() from ext4_get_group_info() Fabio M. De Francesco
2023-06-15 14:59 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168683994079.282246.8360074850989025705.b4-ty@mit.edu \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=fmdefrancesco@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+4acc7d910e617b360859@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).