From: Robert Olsson <Robert.Olsson@data.slu.se>
To: Junfeng Yang <yjf@stanford.edu>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [BUG] 2.6.* pktgen doesn't set ethnet header properly
Date: Fri, 21 Jan 2005 13:22:33 +0100 [thread overview]
Message-ID: <16880.62473.933703.827967@robur.slu.se> (raw)
In-Reply-To: <Pine.GSO.4.44.0501191800030.17705-100000@epic8.Stanford.EDU>
Hello!
Look at
pginfos[i].hh[12] = 0x08; /* fill in protocol. Rest is filled in later. */
pginfos[i].hh[13] = 0x00;
--ro
Junfeng Yang writes:
> Hi,
>
> I tried to use pktgen module from 2.6.* kernels and found out that I
> couldn't receive any packets generated by pktgen. I did not even see a
> "packet dropped by kernel" message. It turned out that function
> setup_inject in net/core/pktgen.c doesn't setup the ethernet header field
> correctly. Below is a patch that fixes the problem.
>
> --- kernel-source-2.6.8-orig/net/core/pktgen.c 2004-08-13 22:37:26.000000000 -0700
> +++ kernel-source-2.6.8/net/core/pktgen.c 2005-01-19 17:54:46.000000000 -0800
> @@ -259,6 +259,9 @@
>
> /* Set up Dest MAC */
> memcpy(&(info->hh[0]), info->dst_mac, 6);
> +
> + /* Set up protocol */
> + ((struct ethhdr *)(info->hh))->h_proto = htons(ETH_P_IP);
>
> info->saddr_min = 0;
> info->saddr_max = 0;
>
> -Junfeng
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
prev parent reply other threads:[~2005-01-21 12:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-20 2:07 [BUG] 2.6.* pktgen doesn't set ethnet header properly Junfeng Yang
2005-01-21 12:22 ` Robert Olsson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16880.62473.933703.827967@robur.slu.se \
--to=robert.olsson@data.slu.se \
--cc=linux-kernel@vger.kernel.org \
--cc=yjf@stanford.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).