From: Milian Wolff <milian.wolff@kdab.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-kernel@vger.kernel.org, jolsa@kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] perf script: Fix LBR skid dump problems in brstackinsn
Date: Tue, 11 Dec 2018 21:47:41 +0100 [thread overview]
Message-ID: <1690253.Gbn1XyeY7h@agathebauer> (raw)
In-Reply-To: <20181206225207.eomszl6sq3omrth7@two.firstfloor.org>
[-- Attachment #1: Type: text/plain, Size: 1621 bytes --]
On Donnerstag, 6. Dezember 2018 23:52:07 CET Andi Kleen wrote:
> On Thu, Dec 06, 2018 at 06:29:20PM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Thu, Dec 06, 2018 at 12:51:48PM -0800, Andi Kleen escreveu:
> > > On Thu, Dec 06, 2018 at 02:01:40PM -0300, Arnaldo Carvalho de Melo
wrote:
> > > > Em Mon, Nov 19, 2018 at 09:06:17PM -0800, Andi Kleen escreveu:
> > > > > From: Andi Kleen <ak@linux.intel.com>
> > > > >
> > > > > This is a fix for another instance of the skid problem Milian
> > > > > recently found [1]
> >
> > I think you forgot to add the reference, i.e. what is the url or
> > message-id that this [1] refers to?
>
> Hmm, I thought I saw some patches from Milian for this earlier,
> but now I can't find them. Perhaps I misremember. Milian
> can point to them if they exist and are not just a figment
> of my imagination :-)
I only have very early POC patches, cf.: https://lkml.org/lkml/2018/11/14/608
I've now also pushed that on my WIP branch: https://github.com/milianw/linux/
tree/pebs-callchain-breakage
I haven't had the time since to work on this. The patches as-is are not
upstreamable. There are some open questions on my side (see mail referenced
above).
> These were the changes to report the stack frame RIP/RSP in the PEBS
> handler and use it for unwinding in perf.
Yes, I was looking at something different. I've no experience with brstackinsn
usage in perf, so I can't really add my tested-by.
Cheers
--
Milian Wolff | milian.wolff@kdab.com | Senior Software Engineer
KDAB (Deutschland) GmbH, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Qt, C++ and OpenGL Experts
[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 3826 bytes --]
next prev parent reply other threads:[~2018-12-11 20:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-20 5:06 [PATCH] perf script: Fix LBR skid dump problems in brstackinsn Andi Kleen
2018-12-06 17:01 ` Arnaldo Carvalho de Melo
2018-12-06 20:51 ` Andi Kleen
2018-12-06 21:29 ` Arnaldo Carvalho de Melo
2018-12-06 22:52 ` Andi Kleen
2018-12-11 20:47 ` Milian Wolff [this message]
2018-12-07 9:21 ` Adrian Hunter
2019-01-03 13:13 ` [tip:perf/urgent] " tip-bot for Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1690253.Gbn1XyeY7h@agathebauer \
--to=milian.wolff@kdab.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).