From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A51BC17440 for ; Tue, 12 Nov 2019 23:14:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 22ABD214E0 for ; Tue, 12 Nov 2019 23:14:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=chronox.de header.i=@chronox.de header.b="QSYazGdg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727145AbfKLXOV (ORCPT ); Tue, 12 Nov 2019 18:14:21 -0500 Received: from mo4-p03-ob.smtp.rzone.de ([85.215.255.100]:27973 "EHLO mo4-p03-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727031AbfKLXOU (ORCPT ); Tue, 12 Nov 2019 18:14:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1573600458; s=strato-dkim-0002; d=chronox.de; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=VtgFCnJQ28ddShV9oBzN0C3DruOGikYUIYBF103YZk4=; b=QSYazGdgv+homWRpsX7658WQKmqv6RthXGBMoXvQPpvmne0/8KVZSZS7RHPYQNZKJY Mqj+gxdSWv/2Td2CNqrXQg/GL8zSb8BMu/p2HWjgEXSG0RXzz6dgEI901vcDEB5w0dcQ vxHqhIbRqLJDHsApWhlYJnjja6jGHXtBaz2q9gAuIHgZxf+3hWO688ZHpO6unldp1P/w p3bBX+EDBKnK6Pozk+cOmbFUTVyulzR++PxBmariQCUGD4wPUzVM5MlAGlFi0VUFpBrD zshC/amxP5WfTXWOIp4MRXu6QEAkgxJRKC+6/T25vCJxf+mMpKTs8yNCfMhF7z+eY+cD Sf3A== X-RZG-AUTH: ":P2ERcEykfu11Y98lp/T7+hdri+uKZK8TKWEqNyiHySGSa9k9zmwdNLqV/Nz7PsNPEA==" X-RZG-CLASS-ID: mo00 Received: from positron.chronox.de by smtp.strato.de (RZmta 44.29.0 SBL|AUTH) with ESMTPSA id N09a57vACNDBA3X (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (curve secp521r1 with 521 ECDH bits, eq. 15360 bits RSA)) (Client did not present a certificate); Wed, 13 Nov 2019 00:13:11 +0100 (CET) From: Stephan =?ISO-8859-1?Q?M=FCller?= To: kbuild test robot Cc: kbuild-all@lists.01.org, Arnd Bergmann , Greg Kroah-Hartman , linux-crypto@vger.kernel.org, LKML , linux-api@vger.kernel.org, "Eric W. Biederman" , "Alexander E. Patrakov" , "Ahmed S. Darwish" , "Theodore Y. Ts'o" , Willy Tarreau , Matthew Garrett , Vito Caputo , Andreas Dilger , Jan Kara , Ray Strode , William Jon McCann , zhangjs , Andy Lutomirski , Florian Weimer , Lennart Poettering , Nicolai Stange , "Peter, Matthias" , Marcelo Henrique Cerri , Roman Drahtmueller , Neil Horman Subject: Re: [PATCH v24 12/12] LRNG - add interface for gathering of raw entropy Date: Wed, 13 Nov 2019 00:13:09 +0100 Message-ID: <16924163.rk3kQpxnsR@positron.chronox.de> In-Reply-To: <201911130440.pXLcGJwR%lkp@intel.com> References: <3516786.qqN2r2gKvT@positron.chronox.de> <201911130440.pXLcGJwR%lkp@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Dienstag, 12. November 2019, 21:55:10 CET schrieb kbuild test robot: Hi kbuild, > Hi "Stephan, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on char-misc/char-misc-testing] > [also build test WARNING on v5.4-rc7 next-20191111] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system. BTW, we also suggest to use '--base' option to > specify the base tree in git format-patch, please see > https://stackoverflow.com/a/37406982] > > url: > https://github.com/0day-ci/linux/commits/Stephan-M-ller/dev-random-a-new-ap > proach-with-full-SP800-90B-compliance/20191113-040847 base: > https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git > 01b59c763fe2de845b65900485b141fdd7bbf93e config: sh-allmodconfig (attached > as .config) > compiler: sh4-linux-gcc (GCC) 7.4.0 > reproduce: > wget > https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O > ~/bin/make.cross chmod +x ~/bin/make.cross > # save the attached .config to linux build tree > GCC_VERSION=7.4.0 make.cross ARCH=sh > > If you fix the issue, kindly add following tag > Reported-by: kbuild test robot > > All warnings (new ones prefixed by >>): > > drivers/char/lrng/lrng_testing.c: In function 'lrng_raw_extract_user': > >> drivers/char/lrng/lrng_testing.c:237:1: warning: the frame size of 1076 > >> bytes is larger than 1024 bytes [-Wframe-larger-than=] > } > ^ > > vim +237 drivers/char/lrng/lrng_testing.c > > 196 > > 197 /********************************************************************** > **** 198 * Debugfs interface > 199 > **************************************************************************/ > 200 static int lrng_raw_extract_user(void __user *buf, size_t nbytes) 201 { > 202 u8 tmp[LRNG_TESTING_RINGBUFFER_SIZE] __aligned(sizeof(u32)); This is the offending line. I will need to kzalloc the code here. Thank you. > 203 int ret = 0, large_request = (nbytes > 256); > 204 > 205 while (nbytes) { > 206 int i; > 207 > 208 if (large_request && need_resched()) { > 209 if (signal_pending(current)) { > 210 if (ret == 0) > 211 ret = -ERESTARTSYS; > 212 break; > 213 } > 214 schedule(); > 215 } > 216 > 217 i = min_t(int, nbytes, sizeof(tmp)); > 218 i = lrng_raw_entropy_reader(tmp, i); > 219 if (i <= 0) { > 220 if (i < 0) > 221 ret = i; > 222 break; > 223 } > 224 if (copy_to_user(buf, tmp, i)) { > 225 ret = -EFAULT; > 226 break; > 227 } > 228 > 229 nbytes -= i; > 230 buf = (u8 *)buf + i; > 231 ret += i; > 232 } > 233 > 234 memzero_explicit(tmp, sizeof(tmp)); > 235 > 236 return ret; > > > 237 } > > 238 > > --- > 0-DAY kernel test infrastructure Open Source Technology > Center https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel > Corporation Ciao Stephan