From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755603AbdDJRKi (ORCPT ); Mon, 10 Apr 2017 13:10:38 -0400 Received: from mail.efficios.com ([167.114.142.141]:35408 "EHLO mail.efficios.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755349AbdDJRKg (ORCPT ); Mon, 10 Apr 2017 13:10:36 -0400 Date: Mon, 10 Apr 2017 17:11:38 +0000 (UTC) From: Mathieu Desnoyers To: rostedt Cc: linux-kernel , Ingo Molnar , Andrew Morton , "Paul E. McKenney" Message-ID: <16945807.6140.1491844298911.JavaMail.zimbra@efficios.com> In-Reply-To: <20170407154304.10a33c8c@gandalf.local.home> References: <20170407140106.051135969@goodmis.org> <1475342880.4473.1491585545139.JavaMail.zimbra@efficios.com> <20170407132613.4a9fa430@gandalf.local.home> <1679331943.4538.1491587357083.JavaMail.zimbra@efficios.com> <20170407141018.21e7d361@gandalf.local.home> <158560784.4550.1491589063819.JavaMail.zimbra@efficios.com> <20170407154117.253c84ae@gandalf.local.home> <20170407154304.10a33c8c@gandalf.local.home> Subject: Re: [PATCH 7/5 v4] tracing: Make sure rcu_irq_enter() can work for trace_*_rcuidle() trace events MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [167.114.142.141] X-Mailer: Zimbra 8.7.6_GA_1776 (ZimbraWebClient - FF45 (Linux)/8.7.6_GA_1776) Thread-Topic: tracing: Make sure rcu_irq_enter() can work for trace_*_rcuidle() trace events Thread-Index: nFw3MBuacQVtzvTlccp5BlmNdn5pTw== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ----- On Apr 7, 2017, at 3:43 PM, rostedt rostedt@goodmis.org wrote: > On Fri, 7 Apr 2017 15:41:17 -0400 > Steven Rostedt wrote: > >> #ifndef MODULE >> -#define __DECLARE_TRACE_RCU(name, proto, args, cond, data_proto, data_args) \ >> +#define __DECLARE_TRACE_RCU(name, proto, args, cond, data_proto, data_args) \ >> static inline void trace_##name##_rcuidle(proto) \ >> { \ >> if (static_key_false(&__tracepoint_##name.key)) \ >> __DO_TRACE(&__tracepoint_##name, \ >> TP_PROTO(data_proto), \ >> TP_ARGS(data_args), \ >> - TP_CONDITION(cond), \ >> - rcu_irq_enter_irqson(), \ >> - rcu_irq_exit_irqson()); \ >> + TP_CONDITION(cond),1); \ > > I'm going to update this patch to add a space before the 1. > >> } >> #else >> #define __DECLARE_TRACE_RCU(name, proto, args, cond, data_proto, data_args) >> @@ -186,7 +189,7 @@ extern void syscall_unregfunc(void); >> __DO_TRACE(&__tracepoint_##name, \ >> TP_PROTO(data_proto), \ >> TP_ARGS(data_args), \ >> - TP_CONDITION(cond),,); \ >> + TP_CONDITION(cond),0); \ > > And before the 0. With those cosmetic changes, I'm ok with it. Acked-by: Mathieu Desnoyers Thanks! Mathieu > > -- Steve > >> if (IS_ENABLED(CONFIG_LOCKDEP) && (cond)) { \ >> rcu_read_lock_sched_notrace(); \ > > rcu_dereference_sched(__tracepoint_##name.funcs);\ -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com