From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932968AbcBAOXB (ORCPT <rfc822;w@1wt.eu>);
	Mon, 1 Feb 2016 09:23:01 -0500
Received: from gloria.sntech.de ([95.129.55.99]:59705 "EHLO gloria.sntech.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932417AbcBAOW5 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 1 Feb 2016 09:22:57 -0500
From: Heiko =?ISO-8859-1?Q?St=FCbner?= <heiko@sntech.de>
To: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        Arnd Bergmann <arnd@arndb.de>, Shawn Guo <shawnguo@kernel.org>,
        Russell King <linux@arm.linux.org.uk>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Hauke Mehrtens <hauke@hauke-m.de>, Rob Herring <robh+dt@kernel.org>,
        Masahiro Yamada <yamada.masahiro@socionext.com>, guohanjun@huawei.com,
        Nicolas Ferre <nicolas.ferre@atmel.com>, Ray Jui <rjui@broadcom.com>,
        Lee Jones <lee@kernel.org>, Krzysztof Halasa <khalasa@piap.pl>,
        Kukjin Kim <kgene@kernel.org>, Rob Herring <robh@kernel.org>,
        Santosh Shilimkar <ssantosh@kernel.org>,
        Roland Stigge <stigge@antcom.de>, Jason Cooper <jason@lakedaemon.net>,
        Haojian Zhuang <haojian.zhuang@gmail.com>,
        Viresh Kumar <vireshk@kernel.org>,
        Shiraz Hashim <shiraz.linux.kernel@gmail.com>,
        Tony Prisk <linux@prisktech.co.nz>
Subject: Re: [PATCH v2 01/15] arm: use of_platform_default_populate() to populate default bus
Date: Mon, 01 Feb 2016 15:22:44 +0100
Message-ID: <1694609.jjsREDbl4R@diego>
User-Agent: KMail/4.14.10 (Linux/4.2.0-1-amd64; KDE/4.14.14; x86_64; ; )
In-Reply-To: <1453881180-12296-1-git-send-email-wangkefeng.wang@huawei.com>
References: <1453868872-26300-2-git-send-email-wangkefeng.wang@huawei.com> <1453881180-12296-1-git-send-email-wangkefeng.wang@huawei.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am Mittwoch, 27. Januar 2016, 15:53:00 schrieb Kefeng Wang:
> Use helper of_platform_default_populate() in linux/of_platform
> when possible, instead of calling of_platform_populate() with
> the default match table.
> 
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---


> diff --git a/arch/arm/mach-rockchip/rockchip.c
> b/arch/arm/mach-rockchip/rockchip.c index 3f07cc5..07ef8ef 100644
> --- a/arch/arm/mach-rockchip/rockchip.c
> +++ b/arch/arm/mach-rockchip/rockchip.c
> @@ -73,7 +73,7 @@ static void __init rockchip_timer_init(void)
>  static void __init rockchip_dt_init(void)
>  {
>  	rockchip_suspend_init();
> -	of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
> +	of_platform_default_populate(NULL, NULL, NULL);
>  	platform_device_register_simple("cpufreq-dt", 0, NULL, 0);
>  }

sounds sensible, so

Acked-by: Heiko Stuebner <heiko@sntech.de>