From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A858E728CF for ; Fri, 29 Sep 2023 19:15:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233869AbjI2TPL (ORCPT ); Fri, 29 Sep 2023 15:15:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233833AbjI2TPH (ORCPT ); Fri, 29 Sep 2023 15:15:07 -0400 Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BCB931B2 for ; Fri, 29 Sep 2023 12:15:05 -0700 (PDT) Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-1bf6ea270b2so112632075ad.0 for ; Fri, 29 Sep 2023 12:15:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1696014905; x=1696619705; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KmMPdMlbowfuuOi3X39k2z6HWTuyzAeHfZfHAs6NLF0=; b=OUTLXWtYVQPgkaebeNFLyZAu2ko3rcGSnQKLQ6RYftoxkI/kt4QaG8/L18pUtK7EOG zz7m6UTYOhafAcv5Qi+uAVAcubDpBeAgoXMoQywGbPZP3iTS4VqhQpT57DHFClbR58dD XlDMsVKo6CBzCzNGKDbHGkFeDy5g5gQYBZwKI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696014905; x=1696619705; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KmMPdMlbowfuuOi3X39k2z6HWTuyzAeHfZfHAs6NLF0=; b=W5RLI7U3WiKlxd4dMr3INssuU/qqrJjM0XvscKk9naeSrM/rNcSSk7qST8Dph+Kwge WHUIAAS8tgioh/sXyjo0NC7OjlTDt+fEny858kEYwv/1qWn/esLqMEFleAt6Qw3/rd18 5uJkd7kCIkPjKaAh1KmRgWu8nJdfaZPEPVrEFbrTkpUOaalhpVuIs/NVvO9/CSA0xBLP W6qu0hcxc5777dGPyWErVnqsMxZ76nl3BY6O76Z1jwR1DUu2qQfkkleqeVpgcURuTu4+ XrAZnEpEXb7LbyjYuwHq8y78PlRD5l1UJXCQg1oy5jn5Njm8NYBzBrBYFfhx1UeTL2bg 09/A== X-Gm-Message-State: AOJu0YxPqNYibMB0STHWV1YR/xhygbB7hGI9HDVEdiQyix+aP4ReaVg6 9gdthNLmFN8mE1LIBr/zGFvSCQ== X-Google-Smtp-Source: AGHT+IHn9fG24NkWQSop20WR8dA5EVPPJq+6v8Bm1V0s5HHwqRAUVrK+MKpf1w8l16fN1Y00fR7gjw== X-Received: by 2002:a17:902:ecc1:b0:1c5:d8a3:8789 with SMTP id a1-20020a170902ecc100b001c5d8a38789mr5938636plh.4.1696014905256; Fri, 29 Sep 2023 12:15:05 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id j12-20020a170902c3cc00b001c72d5e16acsm4109005plj.57.2023.09.29.12.15.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Sep 2023 12:15:03 -0700 (PDT) From: Kees Cook To: =?UTF-8?q?Noralf=20Tr=C3=B8nnes?= , David Airlie , Daniel Vetter , Peter Stuge , "Gustavo A. R. Silva" Cc: Kees Cook , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH][next] drm/gud: Use size_add() in call to struct_size() Date: Fri, 29 Sep 2023 12:15:00 -0700 Message-Id: <169601489950.3012131.9568928913525935036.b4-ty@chromium.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 15 Sep 2023 12:43:20 -0600, Gustavo A. R. Silva wrote: > If, for any reason, the open-coded arithmetic causes a wraparound, the > protection that `struct_size()` adds against potential integer overflows > is defeated. Fix this by hardening call to `struct_size()` with `size_add()`. > > Applied to for-next/hardening, thanks! [1/1] drm/gud: Use size_add() in call to struct_size() https://git.kernel.org/kees/c/836ccb46073e Take care, -- Kees Cook