From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38B85CDB482 for ; Wed, 18 Oct 2023 10:32:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229778AbjJRKcz (ORCPT ); Wed, 18 Oct 2023 06:32:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34084 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229482AbjJRKcw (ORCPT ); Wed, 18 Oct 2023 06:32:52 -0400 Received: from mail-oi1-f169.google.com (mail-oi1-f169.google.com [209.85.167.169]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9A15BA; Wed, 18 Oct 2023 03:32:50 -0700 (PDT) Received: by mail-oi1-f169.google.com with SMTP id 5614622812f47-3b2b1af09c5so2710888b6e.0; Wed, 18 Oct 2023 03:32:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697625170; x=1698229970; h=date:subject:message-id:references:in-reply-to:cc:to:from :mime-version:content-transfer-encoding:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Dg5d8SDlSlp62Ln+IjkIa1gYxVR7adVppGs8QF8Exl4=; b=K3pAfIWVRAhldE4tHtTLVoY503rA/kuzDmW0/8YZlVjOrsbcZeMCBghwUsoPoY5MMZ bW6EdD4M+Wu3fKtgHDaC6f/g/yJnXYibLnEjBLLsh061KHbvHX+a8YsV5u6baRZnOLFn Esao7dAigHk9mX3qYkzg3GCAtp2sPH9rIggZjTNDp5OtrzRHBKlIr81MdIbQGH5OqxmS V11Dimrap+Nj/tnj4pKe7jrqL8qfZagkP7+PXbxI9fEc9wVPlbKCOsUDBN3AUrj/rKB1 q6MvVJsV9KvlLSgE2OcbHwHOugHW9D+dYXaJgJG7sVTZKw+uP4X6YbcgV1q66EHroQP2 ETzw== X-Gm-Message-State: AOJu0YwoQ6k/MMPt8Cj6QhLctAKILQiNBBEctwhqCMKZZzoBLTllnGA3 U3GdDJToMSo1uLvZMpqSkg== X-Google-Smtp-Source: AGHT+IHviX6UrIwh06mLdMonHxveecpCE8DWO90wIhrcz1SbC/uPTFpaZVLY5Sw4GTzxzyU2gDNwHA== X-Received: by 2002:a54:4693:0:b0:3a7:52b9:cbfe with SMTP id k19-20020a544693000000b003a752b9cbfemr4462272oic.32.1697625169886; Wed, 18 Oct 2023 03:32:49 -0700 (PDT) Received: from herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id r24-20020a056808211800b003b2e2d134a5sm390772oiw.35.2023.10.18.03.32.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Oct 2023 03:32:49 -0700 (PDT) Received: (nullmailer pid 391914 invoked by uid 1000); Wed, 18 Oct 2023 10:32:48 -0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 From: Rob Herring To: Linus Walleij Cc: Christian Marangi , Andrew Lunn , Florian Fainelli , linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , Russell King , devicetree@vger.kernel.org, Conor Dooley , Sebastian Hesselbarth , Eric Dumazet , Vladimir Oltean , Rob Herring , netdev@vger.kernel.org, Jakub Kicinski , Paolo Abeni , "David S. Miller" , linux-kernel@vger.kernel.org, Gregory Clement In-Reply-To: <20231018-marvell-88e6152-wan-led-v4-1-3ee0c67383be@linaro.org> References: <20231018-marvell-88e6152-wan-led-v4-0-3ee0c67383be@linaro.org> <20231018-marvell-88e6152-wan-led-v4-1-3ee0c67383be@linaro.org> Message-Id: <169762516670.391804.7528295251386913602.robh@kernel.org> Subject: Re: [PATCH net-next v4 1/7] dt-bindings: net: dsa: Require ports or ethernet-ports Date: Wed, 18 Oct 2023 05:32:48 -0500 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 18 Oct 2023 11:03:40 +0200, Linus Walleij wrote: > Bindings using dsa.yaml#/$defs/ethernet-ports specify that > a DSA switch node need to have a ports or ethernet-ports > subnode, and that is actually required, so add requirements > using oneOf. > > Suggested-by: Rob Herring > Signed-off-by: Linus Walleij > --- > Documentation/devicetree/bindings/net/dsa/dsa.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/net/dsa/dsa.yaml:60:7: [warning] wrong indentation: expected 8 but found 6 (indentation) ./Documentation/devicetree/bindings/net/dsa/dsa.yaml:62:7: [warning] wrong indentation: expected 8 but found 6 (indentation) dtschema/dtc warnings/errors: Traceback (most recent call last): File "/usr/local/bin/dt-doc-validate", line 64, in ret |= check_doc(f) ^^^^^^^^^^^^ File "/usr/local/bin/dt-doc-validate", line 32, in check_doc for error in sorted(dtsch.iter_errors(), key=lambda e: e.linecol): ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.11/dist-packages/dtschema/schema.py", line 125, in iter_errors self.annotate_error(scherr, meta_schema, scherr.schema_path) File "/usr/local/lib/python3.11/dist-packages/dtschema/schema.py", line 104, in annotate_error schema = schema[p] ~~~~~~^^^ KeyError: 'type' doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20231018-marvell-88e6152-wan-led-v4-1-3ee0c67383be@linaro.org The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.