[PATCH] USB: dummy-hcd: fix power budget for SuperSpeed mode

[PATCH] USB: dummy-hcd: fix power budget for SuperSpeed mode

[Jacky.Cao]

The power budget for SuperSpeed mode should be 900 mA
according to USB3.0 specification, so set the power
budget to 900 mA for dummy_start_ss which is only used
for SuperSpeed mode.

If the max power consumption of SuperSpeed device is
larger than 500 mA, insufficient available bus power
error happens in usb_choose_configuration function
when the device connects to dummy hcd.

Signed-off-by: Jacky Cao <Jacky.Cao@sony.com>
---
drivers/usb/gadget/udc/dummy_hcd.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/udc/dummy_hcd.c b/drivers/usb/gadget/udc/dummy_hcd.c
index 8414fac..52f2cf5 100644
--- a/drivers/usb/gadget/udc/dummy_hcd.c
+++ b/drivers/usb/gadget/udc/dummy_hcd.c
@@ -48,6 +48,7 @@
#define DRIVER_VERSION "02 May 2005"

 #define POWER_BUDGET  500  /* in mA; use 8 for low-power port testing */
+#define POWER_BUDGET_3_0  900  /* in mA */

 static const char  driver_name[] = "dummy_hcd";
static const char  driver_desc[] = "USB Host+Gadget Emulator";
@@ -2432,7 +2433,7 @@ static int dummy_start_ss(struct dummy_hcd *dum_hcd)
     dum_hcd->rh_state = DUMMY_RH_RUNNING;
     dum_hcd->stream_en_ep = 0;
     INIT_LIST_HEAD(&dum_hcd->urbp_list);
-     dummy_hcd_to_hcd(dum_hcd)->power_budget = POWER_BUDGET;
+     dummy_hcd_to_hcd(dum_hcd)->power_budget = POWER_BUDGET_3_0;
     dummy_hcd_to_hcd(dum_hcd)->state = HC_STATE_RUNNING;
     dummy_hcd_to_hcd(dum_hcd)->uses_new_polling = 1;
#ifdef CONFIG_USB_OTG
-- 
2.7.4

Re: [PATCH] USB: dummy-hcd: fix power budget for SuperSpeed mode

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 1666 bytes --]


Hi,

<Jacky.Cao@sony.com> writes:

> The power budget for SuperSpeed mode should be 900 mA
> according to USB3.0 specification, so set the power
> budget to 900 mA for dummy_start_ss which is only used
> for SuperSpeed mode.
>
> If the max power consumption of SuperSpeed device is
> larger than 500 mA, insufficient available bus power
> error happens in usb_choose_configuration function
> when the device connects to dummy hcd.
>
> Signed-off-by: Jacky Cao <Jacky.Cao@sony.com>
> ---
> drivers/usb/gadget/udc/dummy_hcd.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/udc/dummy_hcd.c b/drivers/usb/gadget/udc/dummy_hcd.c
> index 8414fac..52f2cf5 100644
> --- a/drivers/usb/gadget/udc/dummy_hcd.c
> +++ b/drivers/usb/gadget/udc/dummy_hcd.c
> @@ -48,6 +48,7 @@
> #define DRIVER_VERSION "02 May 2005"
>
>  #define POWER_BUDGET  500  /* in mA; use 8 for low-power port testing */
> +#define POWER_BUDGET_3_0  900  /* in mA */
>
>  static const char  driver_name[] = "dummy_hcd";
> static const char  driver_desc[] = "USB Host+Gadget Emulator";
> @@ -2432,7 +2433,7 @@ static int dummy_start_ss(struct dummy_hcd *dum_hcd)
>      dum_hcd->rh_state = DUMMY_RH_RUNNING;
>      dum_hcd->stream_en_ep = 0;
>      INIT_LIST_HEAD(&dum_hcd->urbp_list);
> -     dummy_hcd_to_hcd(dum_hcd)->power_budget = POWER_BUDGET;
> +     dummy_hcd_to_hcd(dum_hcd)->power_budget = POWER_BUDGET_3_0;
>      dummy_hcd_to_hcd(dum_hcd)->state = HC_STATE_RUNNING;
>      dummy_hcd_to_hcd(dum_hcd)->uses_new_polling = 1;
> #ifdef CONFIG_USB_OTG

Alan, I suppose you're okay with this change?

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

Re: [PATCH] USB: dummy-hcd: fix power budget for SuperSpeed mode

[Greg KH]

On Wed, Sep 04, 2019 at 10:54:28AM +0300, Felipe Balbi wrote:
> 
> Hi,
> 
> <Jacky.Cao@sony.com> writes:
> 
> > The power budget for SuperSpeed mode should be 900 mA
> > according to USB3.0 specification, so set the power
> > budget to 900 mA for dummy_start_ss which is only used
> > for SuperSpeed mode.
> >
> > If the max power consumption of SuperSpeed device is
> > larger than 500 mA, insufficient available bus power
> > error happens in usb_choose_configuration function
> > when the device connects to dummy hcd.
> >
> > Signed-off-by: Jacky Cao <Jacky.Cao@sony.com>
> > ---
> > drivers/usb/gadget/udc/dummy_hcd.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/usb/gadget/udc/dummy_hcd.c b/drivers/usb/gadget/udc/dummy_hcd.c
> > index 8414fac..52f2cf5 100644
> > --- a/drivers/usb/gadget/udc/dummy_hcd.c
> > +++ b/drivers/usb/gadget/udc/dummy_hcd.c
> > @@ -48,6 +48,7 @@
> > #define DRIVER_VERSION "02 May 2005"
> >
> >  #define POWER_BUDGET  500  /* in mA; use 8 for low-power port testing */
> > +#define POWER_BUDGET_3_0  900  /* in mA */
> >
> >  static const char  driver_name[] = "dummy_hcd";
> > static const char  driver_desc[] = "USB Host+Gadget Emulator";
> > @@ -2432,7 +2433,7 @@ static int dummy_start_ss(struct dummy_hcd *dum_hcd)
> >      dum_hcd->rh_state = DUMMY_RH_RUNNING;
> >      dum_hcd->stream_en_ep = 0;
> >      INIT_LIST_HEAD(&dum_hcd->urbp_list);
> > -     dummy_hcd_to_hcd(dum_hcd)->power_budget = POWER_BUDGET;
> > +     dummy_hcd_to_hcd(dum_hcd)->power_budget = POWER_BUDGET_3_0;
> >      dummy_hcd_to_hcd(dum_hcd)->state = HC_STATE_RUNNING;
> >      dummy_hcd_to_hcd(dum_hcd)->uses_new_polling = 1;
> > #ifdef CONFIG_USB_OTG
> 
> Alan, I suppose you're okay with this change?

I'm not ok with the whitespace damage making this patch impossible to
apply :)

RE: [PATCH] USB: dummy-hcd: fix power budget for SuperSpeed mode

[Jacky.Cao]

Hi, 

> I'm not ok with the whitespace damage making this patch impossible to apply :)

Sorry for the whitespace damage issue I didn't notice when I copied the content.
Just now I submitted v2 for this patch with whitespace damage issue fix.
Please help to confirm, thank you.

Regards
Jacky

Re: [PATCH] USB: dummy-hcd: fix power budget for SuperSpeed mode

[Greg KH]

On Wed, Sep 04, 2019 at 08:52:12AM +0000, Jacky.Cao@sony.com wrote:
> Hi, 
> 
> > I'm not ok with the whitespace damage making this patch impossible to apply :)
> 
> Sorry for the whitespace damage issue I didn't notice when I copied the content.
> Just now I submitted v2 for this patch with whitespace damage issue fix.
> Please help to confirm, thank you.

You can always confirm your own submissions by looking on the mailing
list itself, no need to ask anyone else to do that :)

greg k-h

Re: [PATCH] USB: dummy-hcd: fix power budget for SuperSpeed mode

[Alan Stern]

On Wed, 4 Sep 2019, Felipe Balbi wrote:

> 
> Hi,
> 
> <Jacky.Cao@sony.com> writes:
> 
> > The power budget for SuperSpeed mode should be 900 mA
> > according to USB3.0 specification, so set the power
> > budget to 900 mA for dummy_start_ss which is only used
> > for SuperSpeed mode.
> >
> > If the max power consumption of SuperSpeed device is
> > larger than 500 mA, insufficient available bus power
> > error happens in usb_choose_configuration function
> > when the device connects to dummy hcd.
> >
> > Signed-off-by: Jacky Cao <Jacky.Cao@sony.com>
> > ---
> > drivers/usb/gadget/udc/dummy_hcd.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/usb/gadget/udc/dummy_hcd.c b/drivers/usb/gadget/udc/dummy_hcd.c
> > index 8414fac..52f2cf5 100644
> > --- a/drivers/usb/gadget/udc/dummy_hcd.c
> > +++ b/drivers/usb/gadget/udc/dummy_hcd.c
> > @@ -48,6 +48,7 @@
> > #define DRIVER_VERSION "02 May 2005"
> >
> >  #define POWER_BUDGET  500  /* in mA; use 8 for low-power port testing */
> > +#define POWER_BUDGET_3_0  900  /* in mA */
> >
> >  static const char  driver_name[] = "dummy_hcd";
> > static const char  driver_desc[] = "USB Host+Gadget Emulator";
> > @@ -2432,7 +2433,7 @@ static int dummy_start_ss(struct dummy_hcd *dum_hcd)
> >      dum_hcd->rh_state = DUMMY_RH_RUNNING;
> >      dum_hcd->stream_en_ep = 0;
> >      INIT_LIST_HEAD(&dum_hcd->urbp_list);
> > -     dummy_hcd_to_hcd(dum_hcd)->power_budget = POWER_BUDGET;
> > +     dummy_hcd_to_hcd(dum_hcd)->power_budget = POWER_BUDGET_3_0;
> >      dummy_hcd_to_hcd(dum_hcd)->state = HC_STATE_RUNNING;
> >      dummy_hcd_to_hcd(dum_hcd)->uses_new_polling = 1;
> > #ifdef CONFIG_USB_OTG
> 
> Alan, I suppose you're okay with this change?

Yes.  Except that I think the name POWER_BUDGET_3_0 is a little odd.  
It implies that this change is specific to USB 3.0 -- but it isn't.  
USB 3.1 and 3.2 also have a 900 mA limit, right?

So please consider changing the name to POWER_BUDGET_3.

Alan Stern

RE: [PATCH] USB: dummy-hcd: fix power budget for SuperSpeed mode

[Jacky.Cao]

Hi 

> Yes.  Except that I think the name POWER_BUDGET_3_0 is a little odd.
> It implies that this change is specific to USB 3.0 -- but it isn't.
> USB 3.1 and 3.2 also have a 900 mA limit, right?
> 
> So please consider changing the name to POWER_BUDGET_3.
> 
> Alan Stern

Thank you for your comment.
I updated the name from POWER_BUDGET_3_0 to POWER_BUDGET_3 in PATCH v3
and submitted it just now.

Regards
Jacky

RE: [PATCH] USB: dummy-hcd: fix power budget for SuperSpeed mode

[Jacky.Cao]

Hi

>You must send plain/text emails. I'm not receiving this via the mailing list. Please, fix your email client or use git send-email
Thank you for your information.
I resend mail with text format, would you kind confirm the patch, thank you.

Best Regards
Jacky

-----Original Message-----
From: Felipe Balbi <balbi@kernel.org> 
Sent: Wednesday, September 4, 2019 3:47 PM
To: Cao, Jacky <Jacky.Cao@sony.com>
Cc: Greg KH <gregkh@linuxfoundation.org>; linux-usb@vger.kernel.org; Kernel development list <linux-kernel@vger.kernel.org>; Kobayashi, Kento (Sony) <Kento.A.Kobayashi@sony.com>
Subject: Re: [PATCH] USB: dummy-hcd: fix power budget for SuperSpeed mode

Hi,

On Wed, Sep 4, 2019 at 9:47 AM <Jacky.Cao@sony.com> wrote:
>
> The power budget for SuperSpeed mode should be 900 mA
>
> according to USB3.0 specification, so set the power
>
> budget to 900 mA for dummy_start_ss which is only used
>
> for SuperSpeed mode.
>
>
>
> If the max power consumption of SuperSpeed device is
>
> larger than 500 mA, insufficient available bus power
>
> error happens in usb_choose_configuration function
>
> when the device connects to dummy hcd.
>
>
>
> Signed-off-by: Jacky Cao <Jacky.Cao@sony.com>

You must send plain/text emails. I'm not receiving this via the mailing list. Please, fix your email client or use git send-email

--
balbi

Re: [PATCH] USB: dummy-hcd: fix power budget for SuperSpeed mode

[Felipe Balbi]

Hi,

On Wed, Sep 4, 2019 at 9:47 AM <Jacky.Cao@sony.com> wrote:
>
> The power budget for SuperSpeed mode should be 900 mA
>
> according to USB3.0 specification, so set the power
>
> budget to 900 mA for dummy_start_ss which is only used
>
> for SuperSpeed mode.
>
>
>
> If the max power consumption of SuperSpeed device is
>
> larger than 500 mA, insufficient available bus power
>
> error happens in usb_choose_configuration function
>
> when the device connects to dummy hcd.
>
>
>
> Signed-off-by: Jacky Cao <Jacky.Cao@sony.com>

You must send plain/text emails. I'm not receiving this via the
mailing list. Please, fix your
email client or use git send-email

-- 
balbi

RE: [PATCH] USB: dummy-hcd: fix power budget for SuperSpeed mode

[Kobayashi, Kento (Sony)]

Hi,

>> Hi,
>>
>> My company's member, Mr.Jacky, sent patch in June 26th.
>> But we didn't receive comment about our patch.
>> Could you confirm and tell us this patch is needed or not?
>
>I can't find the original patch in my inbox, could you resend it using git send-email?
>
>Patch seems necessary, indeed.
>
>best regards
>
>--
>balbi

Thank you for replying.
My company member, Mr.Jacky(Jacky.Cao@sony.com) sent again patch at Sep. 4th 15:48(JST).
So could you confirm?
And in our environment,we can't send mail by git send mail.
So he sent by another mail application.

Regards,
Kento Kobayashi 

-----Original Message-----
From: Felipe Balbi <balbi@kernel.org> 
Sent: Wednesday, September 4, 2019 3:20 PM
To: Kobayashi, Kento (Sony) <Kento.A.Kobayashi@sony.com>; gregkh@linuxfoundation.org
Cc: linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org; Cao, Jacky <Jacky.Cao@sony.com>
Subject: RE: [PATCH] USB: dummy-hcd: fix power budget for SuperSpeed mode


Hi,

"Kobayashi, Kento (Sony)" <Kento.A.Kobayashi@sony.com> writes:

> Hi,
>
> My company's member, Mr.Jacky, sent patch in June 26th.
> But we didn't receive comment about our patch.
> Could you confirm and tell us this patch is needed or not?

I can't find the original patch in my inbox, could you resend it using git send-email?

Patch seems necessary, indeed.

best regards

--
balbi

RE: [PATCH] USB: dummy-hcd: fix power budget for SuperSpeed mode

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 411 bytes --]


Hi,

"Kobayashi, Kento (Sony)" <Kento.A.Kobayashi@sony.com> writes:

> Hi,
>
> My company's member, Mr.Jacky, sent patch in June 26th.
> But we didn't receive comment about our patch.
> Could you confirm and tell us this patch is needed or not?

I can't find the original patch in my inbox, could you resend it using
git send-email?

Patch seems necessary, indeed.

best regards

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

RE: [PATCH] USB: dummy-hcd: fix power budget for SuperSpeed mode

[Kobayashi, Kento (Sony)]

Hi,

My company's member, Mr.Jacky, sent patch in June 26th.
But we didn't receive comment about our patch.
Could you confirm and tell us this patch is needed or not?

Regards,
Kento Kobayashi



From: Cao, Jacky <Jacky.Cao@sony.com> 
Sent: Monday, July 15, 2019 10:05 AM
To: balbi@kernel.org; gregkh@linuxfoundation.org
Cc: linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org; Kobayashi, Kento (Sony) <Kento.A.Kobayashi@sony.com>; Cao, Jacky <Jacky.Cao@sony.com>
Subject: RE: [PATCH] USB: dummy-hcd: fix power budget for SuperSpeed mode

Hi, 

Since around half month past, let me confirm the status of this issue.
If any comment about the fix patch, would you kind to share with us? 
Thank you.

Best Regards
Jacky

From: Cao, Jacky 
Sent: Wednesday, June 26, 2019 1:48 PM
To: mailto:balbi@kernel.org; mailto:gregkh@linuxfoundation.org; mailto:linux-usb@vger.kernel.org; mailto:linux-kernel@vger.kernel.org
Cc: Kobayashi, Kento (Sony) <mailto:Kento.A.Kobayashi@sony.com>; Cao, Jacky <mailto:Jacky.Cao@sony.com>
Subject: [PATCH] USB: dummy-hcd: fix power budget for SuperSpeed mode

The power budget for SuperSpeed mode should be 900 mA
according to USB3.0 specification, so set the power
budget to 900 mA for dummy_start_ss which is only used
for SuperSpeed mode.

If the max power consumption of SuperSpeed device is
larger than 500 mA, insufficient available bus power
error happens in usb_choose_configuration function
when the device connects to dummy hcd.

Signed-off-by: Jacky Cao <mailto:Jacky.Cao@sony.com>
---
drivers/usb/gadget/udc/dummy_hcd.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/udc/dummy_hcd.c b/drivers/usb/gadget/udc/dummy_hcd.c
index 8414fac..52f2cf5 100644
--- a/drivers/usb/gadget/udc/dummy_hcd.c
+++ b/drivers/usb/gadget/udc/dummy_hcd.c
@@ -48,6 +48,7 @@
#define DRIVER_VERSION "02 May 2005"

 #define POWER_BUDGET  500  /* in mA; use 8 for low-power port testing */
+#define POWER_BUDGET_3_0  900  /* in mA */

 static const char  driver_name[] = "dummy_hcd";
static const char  driver_desc[] = "USB Host+Gadget Emulator";
@@ -2432,7 +2433,7 @@ static int dummy_start_ss(struct dummy_hcd *dum_hcd)
     dum_hcd->rh_state = DUMMY_RH_RUNNING;
     dum_hcd->stream_en_ep = 0;
     INIT_LIST_HEAD(&dum_hcd->urbp_list);
-     dummy_hcd_to_hcd(dum_hcd)->power_budget = POWER_BUDGET;
+     dummy_hcd_to_hcd(dum_hcd)->power_budget = POWER_BUDGET_3_0;
     dummy_hcd_to_hcd(dum_hcd)->state = HC_STATE_RUNNING;
     dummy_hcd_to_hcd(dum_hcd)->uses_new_polling = 1;
#ifdef CONFIG_USB_OTG
-- 
2.7.4