From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D430C0044B for ; Thu, 8 Nov 2018 23:06:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D145120818 for ; Thu, 8 Nov 2018 23:06:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=dellteam.com header.i=@dellteam.com header.b="JP5CBbu2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D145120818 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=Dellteam.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727523AbeKIIok (ORCPT ); Fri, 9 Nov 2018 03:44:40 -0500 Received: from esa3.dell-outbound.iphmx.com ([68.232.153.94]:13571 "EHLO esa3.dell-outbound.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725922AbeKIIok (ORCPT ); Fri, 9 Nov 2018 03:44:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=dellteam.com; i=@dellteam.com; q=dns/txt; s=smtpout; t=1541718394; x=1573254394; h=cc:from:to:subject:date:message-id:references: content-transfer-encoding:mime-version; bh=q1w9LkC4ZTIx5rWLtT8VNvzDkq8GAD9EkKMaQzTUbng=; b=JP5CBbu2uci2iMX5CNu17MSeYgF5paDm3yWnxs4crpNpEZoIqsngvg2z Cp8OttvPmcVs3biVWxcH7DtF8mQ1oiGYk8eF/ZJyib7SHUsRrxptSmUKX 0Q/QpenTr1xqNdBP6w+seLgdoUNpabLeKRxQREwduyJU7tBXdFnpU7dCI Y=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2EQAAD3wORbhiWd50NkHAEBAQQBAQc?= =?us-ascii?q?EAQGBUQcBAQsBg2snCowGX4sdgg2XMhSBZgsBAYRsgxsiNA0NAQMBAQIBAQI?= =?us-ascii?q?BAQIQAQEBCgkLCCkvgjYigmQBAQEDEig/EAIBCBgeEFcCBBMIFgSCf4ICnHY?= =?us-ascii?q?CgRCJWAEBAYIciiyLeYIXgRGDEoRmGE2FDgKKfZRLCQWRCSCBV4gjhnKCdJR?= =?us-ascii?q?VAgQCBAUCFIFDgg5wgzyCNRuOCkABMYw2gR8BAQ?= X-IPAS-Result: =?us-ascii?q?A2EQAAD3wORbhiWd50NkHAEBAQQBAQcEAQGBUQcBAQsBg?= =?us-ascii?q?2snCowGX4sdgg2XMhSBZgsBAYRsgxsiNA0NAQMBAQIBAQIBAQIQAQEBCgkLC?= =?us-ascii?q?CkvgjYigmQBAQEDEig/EAIBCBgeEFcCBBMIFgSCf4ICnHYCgRCJWAEBAYIci?= =?us-ascii?q?iyLeYIXgRGDEoRmGE2FDgKKfZRLCQWRCSCBV4gjhnKCdJRVAgQCBAUCFIFDg?= =?us-ascii?q?g5wgzyCNRuOCkABMYw2gR8BAQ?= Received: from mx0b-00154901.pphosted.com ([67.231.157.37]) by esa3.dell-outbound.iphmx.com with ESMTP/TLS/AES256-SHA256; 08 Nov 2018 17:06:34 -0600 Received: from pps.filterd (m0144104.ppops.net [127.0.0.1]) by mx0b-00154901.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id wA8N2m3W184620; Thu, 8 Nov 2018 18:06:50 -0500 Received: from esa5.dell-outbound2.iphmx.com (esa5.dell-outbound2.iphmx.com [68.232.153.203]) by mx0b-00154901.pphosted.com with ESMTP id 2nmtq094wp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 08 Nov 2018 18:06:50 -0500 Cc: , , , , , , , , , , , , Received: from ausxippc101.us.dell.com ([143.166.85.207]) by esa5.dell-outbound2.iphmx.com with ESMTP/TLS/DHE-RSA-AES256-SHA256; 09 Nov 2018 05:06:41 +0600 X-LoopCount0: from 10.166.134.83 X-IronPort-AV: E=Sophos;i="5.54,481,1534827600"; d="scan'208";a="1159082747" From: To: Subject: Re: [PATCH v2] PCI/MSI: Don't touch MSI bits when the PCI device is disconnected Thread-Topic: [PATCH v2] PCI/MSI: Don't touch MSI bits when the PCI device is disconnected Thread-Index: AQHUT50UQ290XPGvJEGnaSTTjbCF+g== Date: Thu, 8 Nov 2018 23:06:47 +0000 Message-ID: <16bf9d14bc5f4a90b2b88dd2eb165186@ausx13mps321.AMER.DELL.COM> References: <20180918221501.13112-1-mr.nuke.me@gmail.com> <20181107234257.GC41183@google.com> <20181108200855.GE41183@google.com> <20181108220117.GA11466@kroah.com> <20181108223258.GD2932@localhost.localdomain> <20181108224255.GA20619@kroah.com> <20d68e586fff4dcca5616d5056f6fc21@ausx13mps321.AMER.DELL.COM> <20181108225109.GA3023@kroah.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.177.90.70] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-11-08_13:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1811080194 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/08/2018 04:51 PM, Greg KH wrote:=0A= > On Thu, Nov 08, 2018 at 10:49:08PM +0000, Alex_Gagniuc@Dellteam.com wrote= :=0A= >> In the case that we're trying to fix, this code executing is a result of= =0A= >> the device being gone, so we can guarantee race-free operation. I agree= =0A= >> that there is a race, in the general case. As far as checking the result= =0A= >> for all F's, that's not an option when firmware crashes the system as a= =0A= >> result of the mmio read/write. It's never pretty when firmware gets=0A= >> involved.=0A= > =0A= > If you have firmware that crashes the system when you try to read from a= =0A= > PCI device that was hot-removed, that is broken firmware and needs to be= =0A= > fixed. The kernel can not work around that as again, you will never win= =0A= > that race.=0A= =0A= But it's not the firmware that crashes. It's linux as a result of a =0A= fatal error message from the firmware. And we can't fix that because FFS = =0A= handling requires that the system reboots [1].=0A= =0A= If we're going to say that we don't want to support FFS because it's a =0A= separate code path, and different flow, that's fine. I am myself, not a =0A= fan of FFS. But if we're going to continue supporting it, I think we'll =0A= continue to have to resolve these sort of unintended consequences.=0A= =0A= Alex=0A= =0A= [1] ACPI 6.2, 18.1 - Hardware Errors and Error Sources=0A=