From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC938C28CC5 for ; Wed, 5 Jun 2019 12:30:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A0CD3206BA for ; Wed, 5 Jun 2019 12:30:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727755AbfFEMay (ORCPT ); Wed, 5 Jun 2019 08:30:54 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:41893 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727273AbfFEMay (ORCPT ); Wed, 5 Jun 2019 08:30:54 -0400 Received: by mail-wr1-f66.google.com with SMTP id c2so19283587wrm.8 for ; Wed, 05 Jun 2019 05:30:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=LbP+4Vhj30bq0+PmaAtLxhYGOHZkRbouhUMM/rlGAio=; b=NSSYdLPc2VNUD7/+/Nc7sL1uD4BtfPNOdogzKmKEpKHJ01lJ3MX+yu9ploDrbJhsCg VUUUGBh+7CT9TLnD76Pfcq6cN2vZcDzoUFEqzY/gYE6QM2IqNjIdCXrt5oHQbWmoPVZn pNF2nzSpX1KxhuclCEOZGOxco3ONirkGpf8a7l7oHJLgIkRfURnjU6wTEdzntpLRsEtH 4YhiZ88yvbILNFNSV6v6s2pNN9DXkG7sLg0aV7EyYH9l7986kHzKlVlTUzdKsDOUvekm nQsF4SJmvzkCjX3zcNWsWTCaqbiks8I3Ah/JypCaoEPqwasIPdqVi8dfk8sCEcgdoRdr 7+rg== X-Gm-Message-State: APjAAAV73/uuj8CBjSiB7ObUmKCo5VGqG+J70PuD0i87/OUKpsUtLjj7 LkZzt8toJXcjlzdCPQCu6WUnbGqIDJ4= X-Google-Smtp-Source: APXvYqyvlm5M1bXcrn9GAlNkvwvBbkHrjifqtLlqk0RswqV2sJBC5ghNSb7uw+F4oxs2+AXkRoYKuQ== X-Received: by 2002:adf:a18a:: with SMTP id u10mr2661650wru.351.1559737853018; Wed, 05 Jun 2019 05:30:53 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:657f:501:149f:5617? ([2001:b07:6468:f312:657f:501:149f:5617]) by smtp.gmail.com with ESMTPSA id j15sm10149112wrn.50.2019.06.05.05.30.52 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Wed, 05 Jun 2019 05:30:52 -0700 (PDT) Subject: Re: [PATCH 2/3] KVM: LAPIC: lapic timer is injected by posted interrupt To: Wanpeng Li , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= References: <1559729351-20244-1-git-send-email-wanpengli@tencent.com> <1559729351-20244-3-git-send-email-wanpengli@tencent.com> From: Paolo Bonzini Message-ID: <16c54182-7198-f476-080b-5876cd871e42@redhat.com> Date: Wed, 5 Jun 2019 14:30:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <1559729351-20244-3-git-send-email-wanpengli@tencent.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/06/19 12:09, Wanpeng Li wrote: > +static void apic_timer_expired_pi(struct kvm_lapic *apic) > +{ > + struct kvm_timer *ktimer = &apic->lapic_timer; > + > + kvm_apic_local_deliver(apic, APIC_LVTT); > + if (apic_lvtt_tscdeadline(apic)) > + ktimer->tscdeadline = 0; > + if (apic_lvtt_oneshot(apic)) { > + ktimer->tscdeadline = 0; > + ktimer->target_expiration = 0; > + } > +} Please rename this function to kvm_apic_inject_pending_timer_irqs and call it from kvm_inject_apic_timer_irqs. Then apic_timer_expired can just do if (atomic_read(&apic->lapic_timer.pending)) return; + if (unlikely(posted_interrupt_inject_timer(apic->vcpu))) { + kvm_apic_inject_pending_timer_irqs(apic); + return; + } etc. Paolo