From: David Ahern <dsahern@kernel.org>
To: menglong8.dong@gmail.com, kuba@kernel.org, pabeni@redhat.com
Cc: rostedt@goodmis.org, mingo@redhat.com, xeb@mail.ru,
davem@davemloft.net, yoshfuji@linux-ipv6.org,
imagedong@tencent.com, edumazet@google.com, kafai@fb.com,
talalahmad@google.com, keescook@chromium.org, alobakin@pm.me,
flyingpeng@tencent.com, mengensun@tencent.com,
dongli.zhang@oracle.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, benbjiang@tencent.com
Subject: Re: [PATCH RESEND net-next v5 4/4] net: icmp: add skb drop reasons to icmp protocol
Date: Fri, 8 Apr 2022 22:17:30 -0600 [thread overview]
Message-ID: <16cb992b-f695-0388-25cc-8e41f33b0ee9@kernel.org> (raw)
In-Reply-To: <20220407062052.15907-5-imagedong@tencent.com>
On 4/7/22 12:20 AM, menglong8.dong@gmail.com wrote:
> From: Menglong Dong <imagedong@tencent.com>
>
> Replace kfree_skb() used in icmp_rcv() and icmpv6_rcv() with
> kfree_skb_reason().
>
> In order to get the reasons of the skb drops after icmp message handle,
> we change the return type of 'handler()' in 'struct icmp_control' from
> 'bool' to 'enum skb_drop_reason'. This may change its original
> intention, as 'false' means failure, but 'SKB_NOT_DROPPED_YET' means
> success now. Therefore, all 'handler' and the call of them need to be
> handled. Following 'handler' functions are involved:
>
> icmp_unreach()
> icmp_redirect()
> icmp_echo()
> icmp_timestamp()
> icmp_discard()
>
> And following new drop reasons are added:
>
> SKB_DROP_REASON_ICMP_CSUM
> SKB_DROP_REASON_INVALID_PROTO
>
> The reason 'INVALID_PROTO' is introduced for the case that the packet
> doesn't follow rfc 1122 and is dropped. This is not a common case, and
> I believe we can locate the problem from the data in the packet. For now,
> this 'INVALID_PROTO' is used for the icmp broadcasts with wrong types.
>
> Maybe there should be a document file for these reasons. For example,
> list all the case that causes the 'UNHANDLED_PROTO' and 'INVALID_PROTO'
> drop reason. Therefore, users can locate their problems according to the
> document.
>
> Reviewed-by: Hao Peng <flyingpeng@tencent.com>
> Reviewed-by: Jiang Biao <benbjiang@tencent.com>
> Signed-off-by: Menglong Dong <imagedong@tencent.com>
> ---
> v5:
> - rename SKB_DROP_REASON_RFC_1122 to SKB_DROP_REASON_INVALID_PROTO
>
> v4:
> - remove SKB_DROP_REASON_ICMP_TYPE and SKB_DROP_REASON_ICMP_BROADCAST
> and introduce the SKB_DROP_REASON_RFC_1122
> ---
> include/linux/skbuff.h | 5 +++
> include/net/ping.h | 2 +-
> include/trace/events/skb.h | 2 +
> net/ipv4/icmp.c | 75 ++++++++++++++++++++++----------------
> net/ipv4/ping.c | 14 ++++---
> net/ipv6/icmp.c | 24 +++++++-----
> 6 files changed, 75 insertions(+), 47 deletions(-)
>
Reviewed-by: David Ahern <dsahern@kernel.org>
next prev parent reply other threads:[~2022-04-09 4:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 6:20 [PATCH RESEND net-next v5 0/4] net: icmp: add skb drop reasons to icmp menglong8.dong
2022-04-07 6:20 ` [PATCH RESEND net-next v5 1/4] net: sock: introduce sock_queue_rcv_skb_reason() menglong8.dong
2022-04-09 3:49 ` David Ahern
2022-04-07 6:20 ` [PATCH RESEND net-next v5 2/4] net: skb: rename SKB_DROP_REASON_PTYPE_ABSENT menglong8.dong
2022-04-09 3:50 ` David Ahern
2022-04-07 6:20 ` [PATCH RESEND net-next v5 3/4] net: icmp: introduce __ping_queue_rcv_skb() to report drop reasons menglong8.dong
2022-04-09 4:05 ` David Ahern
2022-04-07 6:20 ` [PATCH RESEND net-next v5 4/4] net: icmp: add skb drop reasons to icmp protocol menglong8.dong
2022-04-09 4:17 ` David Ahern [this message]
2022-04-11 9:50 ` [PATCH RESEND net-next v5 0/4] net: icmp: add skb drop reasons to icmp patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16cb992b-f695-0388-25cc-8e41f33b0ee9@kernel.org \
--to=dsahern@kernel.org \
--cc=alobakin@pm.me \
--cc=benbjiang@tencent.com \
--cc=davem@davemloft.net \
--cc=dongli.zhang@oracle.com \
--cc=edumazet@google.com \
--cc=flyingpeng@tencent.com \
--cc=imagedong@tencent.com \
--cc=kafai@fb.com \
--cc=keescook@chromium.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mengensun@tencent.com \
--cc=menglong8.dong@gmail.com \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rostedt@goodmis.org \
--cc=talalahmad@google.com \
--cc=xeb@mail.ru \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).