From: Lu Baolu <baolu.lu@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Joerg Roedel <jroedel@suse.de>,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Cc: baolu.lu@linux.intel.com, David Woodhouse <dwmw2@infradead.org>,
Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>
Subject: Re: [PATCH v1 1/1] iommu/vt-d: Don't cast parameter in for_each_set_bit()
Date: Thu, 10 Feb 2022 09:19:50 +0800 [thread overview]
Message-ID: <16e2142d-30cf-a4e2-c010-b58301b5392e@linux.intel.com> (raw)
In-Reply-To: <20220209174913.4319-1-andriy.shevchenko@linux.intel.com>
Hi Andy,
On 2/10/22 1:49 AM, Andy Shevchenko wrote:
> While in this particular case it would not be a (critical) issue,
> the pattern itself is bad and error prone in case the location
> of the parameter is changed.
>
> Don't cast parameter to unsigned long pointer in for_each_set_bit().
> Instead copy to a local variable on stack of a proper type and use.
>
> Fixes: 6ee1b77ba3ac ("iommu/vt-d: Add svm/sva invalidate function")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/iommu/intel/iommu.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c
> index 92fea3fbbb11..777e81b8f4f5 100644
> --- a/drivers/iommu/intel/iommu.c
> +++ b/drivers/iommu/intel/iommu.c
> @@ -4973,6 +4973,7 @@ intel_iommu_sva_invalidate(struct iommu_domain *domain, struct device *dev,
> struct dmar_domain *dmar_domain = to_dmar_domain(domain);
> struct device_domain_info *info;
> struct intel_iommu *iommu;
> + unsigned long cache_bits;
> unsigned long flags;
> int cache_type;
> u8 bus, devfn;
> @@ -5008,9 +5009,8 @@ intel_iommu_sva_invalidate(struct iommu_domain *domain, struct device *dev,
> size = to_vtd_size(inv_info->granu.addr_info.granule_size,
> inv_info->granu.addr_info.nb_granules);
>
> - for_each_set_bit(cache_type,
> - (unsigned long *)&inv_info->cache,
> - IOMMU_CACHE_INV_TYPE_NR) {
> + cache_bits = inv_info->cache;
> + for_each_set_bit(cache_type, &cache_bits, IOMMU_CACHE_INV_TYPE_NR) {
> int granu = 0;
> u64 pasid = 0;
> u64 addr = 0;
Thanks for your patch. The function that you are changing becomes dead
code (nobody uses it and there's no plan to use it anymore) now. I
already have a patch to remove this function.
Best regards,
baolu
prev parent reply other threads:[~2022-02-10 1:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-09 17:49 [PATCH v1 1/1] iommu/vt-d: Don't cast parameter in for_each_set_bit() Andy Shevchenko
2022-02-10 1:19 ` Lu Baolu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16e2142d-30cf-a4e2-c010-b58301b5392e@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=jroedel@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).