From: Mark Brown <broonie@kernel.org>
To: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Cc: "Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Heiko Stuebner" <heiko@sntech.de>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>,
"Zhu Ning" <zhuning0077@gmail.com>,
"Pierre-Louis Bossart" <pierre-louis.bossart@linux.intel.com>,
"Charles Keepax" <ckeepax@opensource.cirrus.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"David Yang" <yangxiaohua@everest-semi.com>,
"Daniel Drake" <drake@endlessm.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
alsa-devel@alsa-project.org, kernel@collabora.com
Subject: Re: [PATCH 2/3] ASoC: es8316: Do not set rate constraints for unsupported MCLKs
Date: Wed, 24 May 2023 11:36:34 +0100 [thread overview]
Message-ID: <16e818c0-6917-44d9-8cb6-27bbf41b896c@sirena.org.uk> (raw)
In-Reply-To: <20230524074156.147387-3-cristian.ciocaltea@collabora.com>
[-- Attachment #1: Type: text/plain, Size: 273 bytes --]
On Wed, May 24, 2023 at 10:41:55AM +0300, Cristian Ciocaltea wrote:
> - es8316->sysclk_constraints.list = es8316->allowed_rates;
> + es8316->sysclk_constraints.list = count ? es8316->allowed_rates : NULL;
Please write normal conditional statements to improve legibility.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-05-24 10:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 7:41 [PATCH 0/3] ES8316 audio codec fixes on Rock5B Cristian Ciocaltea
2023-05-24 7:41 ` [PATCH 1/3] ASoC: es8316: Increment max value for ALC Capture Target Volume control Cristian Ciocaltea
2023-05-24 10:30 ` Mark Brown
2023-05-24 13:49 ` Cristian Ciocaltea
2023-05-24 13:59 ` Mark Brown
2023-05-26 18:11 ` Cristian Ciocaltea
2023-05-30 11:36 ` Mark Brown
2023-05-30 12:52 ` Cristian Ciocaltea
2023-05-30 12:55 ` Mark Brown
2023-05-24 7:41 ` [PATCH 2/3] ASoC: es8316: Do not set rate constraints for unsupported MCLKs Cristian Ciocaltea
2023-05-24 10:36 ` Mark Brown [this message]
2023-05-24 7:41 ` [PATCH 3/3] arm64: dts: rockchip: Assign ES8316 MCLK rate on rk3588-rock-5b Cristian Ciocaltea
2023-05-24 10:39 ` Mark Brown
2023-05-24 14:21 ` Cristian Ciocaltea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16e818c0-6917-44d9-8cb6-27bbf41b896c@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=conor+dt@kernel.org \
--cc=cristian.ciocaltea@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=drake@endlessm.com \
--cc=heiko@sntech.de \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=yangxiaohua@everest-semi.com \
--cc=zhuning0077@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).