From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Lubomir Rintel <lkundrak@v3.sk>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: yuehaibing@huawei.com, dri-devel@lists.freedesktop.org,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] pxa168fb: Fix the function used to release some memory in an error handling path
Date: Fri, 3 Jan 2020 13:00:23 +0100 [thread overview]
Message-ID: <1700b70d-7766-bd6b-10ad-149c73e3998e@samsung.com> (raw)
In-Reply-To: <ca0213fd439a2b569e0d3bdb000712ee62ff4836.camel@v3.sk>
On 9/2/19 11:10 AM, Lubomir Rintel wrote:
> On Sat, 2019-08-31 at 12:00 +0200, Christophe JAILLET wrote:
>> In the probe function, some resources are allocated using 'dma_alloc_wc()',
>> they should be released with 'dma_free_wc()', not 'dma_free_coherent()'.
>>
>> We already use 'dma_free_wc()' in the remove function, but not in the
>> error handling path of the probe function.
>>
>> Also, remove a useless 'PAGE_ALIGN()'. 'info->fix.smem_len' is already
>> PAGE_ALIGNed.
>>
>> Fixes: 638772c7553f ("fb: add support of LCD display controller on pxa168/910 (base layer)")
>> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>
> Reviewed-by: Lubomir Rintel <lkundrak@v3.sk>
Thanks, patch queued for v5.6 (also sorry for the delay).
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> Thanks,
> Lubo
>
>> ---
>> The change about PAGE_ALIGN should probably be part of a separate commit.
>> However, git history for this driver is really quiet. If you think it
>> REALLY deserves a separate patch, either split it by yourself or axe this
>> part of the patch. I won't bother resubmitting for this lonely cleanup.
>> Hoping for your understanding.
>> ---
>> drivers/video/fbdev/pxa168fb.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/video/fbdev/pxa168fb.c b/drivers/video/fbdev/pxa168fb.c
>> index 1410f476e135..1fc50fc0694b 100644
>> --- a/drivers/video/fbdev/pxa168fb.c
>> +++ b/drivers/video/fbdev/pxa168fb.c
>> @@ -766,8 +766,8 @@ static int pxa168fb_probe(struct platform_device *pdev)
>> failed_free_clk:
>> clk_disable_unprepare(fbi->clk);
>> failed_free_fbmem:
>> - dma_free_coherent(fbi->dev, info->fix.smem_len,
>> - info->screen_base, fbi->fb_start_dma);
>> + dma_free_wc(fbi->dev, info->fix.smem_len,
>> + info->screen_base, fbi->fb_start_dma);
>> failed_free_info:
>> kfree(info);
>>
>> @@ -801,7 +801,7 @@ static int pxa168fb_remove(struct platform_device *pdev)
>>
>> irq = platform_get_irq(pdev, 0);
>>
>> - dma_free_wc(fbi->dev, PAGE_ALIGN(info->fix.smem_len),
>> + dma_free_wc(fbi->dev, info->fix.smem_len,
>> info->screen_base, info->fix.smem_start);
>>
>> clk_disable_unprepare(fbi->clk);
>
prev parent reply other threads:[~2020-01-03 12:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-31 10:00 [PATCH] pxa168fb: Fix the function used to release some memory in an error handling path Christophe JAILLET
2019-09-02 9:10 ` Lubomir Rintel
2020-01-03 12:00 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1700b70d-7766-bd6b-10ad-149c73e3998e@samsung.com \
--to=b.zolnierkie@samsung.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkundrak@v3.sk \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).