From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751099AbVIUPoR (ORCPT ); Wed, 21 Sep 2005 11:44:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751101AbVIUPoR (ORCPT ); Wed, 21 Sep 2005 11:44:17 -0400 Received: from mx1.redhat.com ([66.187.233.31]:6559 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S1751099AbVIUPoQ (ORCPT ); Wed, 21 Sep 2005 11:44:16 -0400 From: David Howells In-Reply-To: References: <5378.1127211442@warthog.cambridge.redhat.com> <12434.1127314090@warthog.cambridge.redhat.com> To: Linus Torvalds Cc: David Howells , akpm@osdl.org, keyrings@linux-nfs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Keys: Add possessor permissions to keys X-Mailer: MH-E 7.84; nmh 1.1; GNU Emacs 22.0.50.1 Date: Wed, 21 Sep 2005 16:44:04 +0100 Message-ID: <17063.1127317444@warthog.cambridge.redhat.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Linus Torvalds wrote: > Ok, maybe I'm just strange, but when I see code like > > if (is_key_possessed(keyref)) { > > I'm inevitably mentally going "Linda Blair! It is spewing pea-soup and > rotating its head!" > > Maybe not the best of naming practices.. Or maybe not the best of mental or film watching practices? :-) How about if I call it is_key_retained() instead? Of course, I now prefer the name is_key_possessed() if only to frighten other kernel developers... David