Overlayfs rename bug

From: David Howells <dhowells@redhat.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: dhowells@redhat.com, Sedat Dilek <sedat.dilek@gmail.com>,
	"J. R. Okajima" <hooanon05g@gmail.com>,
	Al Viro <viro@zeniv.linux.org.uk>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Christoph Hellwig <hch@infradead.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Robo Bot <apw@canonical.com>, Felix Fietkau <nbd@openwrt.org>,
	Neil Brown <neilb@suse.de>, Jordi Pujol <jordipujolp@gmail.com>,
	ezk@fsl.cs.sunysb.edu, "mszeredi@suse.cz" <mszeredi@suse.cz>
Subject: Overlayfs rename bug
Date: Tue, 24 Jun 2014 17:46:14 +0100	[thread overview]
Message-ID: <17091.1403628374@warthog.procyon.org.uk> (raw)
In-Reply-To: <CAJfpegvSkr4NJJOfPH4MOhYvaLe=yWv_pR9kK4uiRpScyiapig@mail.gmail.com>

Miklos Szeredi <miklos@szeredi.hu> wrote:

> > Tentative Tested-by from me unless I can break it.
> 
> Thanks for testing.

Tested-by retracted temporarily.  There's a bug in rename handling.  If you
clone:

	http://git.infradead.org/users/dhowells/unionmount-testsuite.git

and check out the switch-to-python branch and do:

	./run --no rename-mass

then this works with no unioning used, but if you do:

	./run --ov rename-mass

to run it on overlayfs, then the following occurs:

	[root@andromeda union-testsuite]# ./run --ov rename-mass
	***
	*** ./run --ov --ts=0 rename-mass
	***
	TEST rename-mass.py:15: Mass rename sequential files into each other's vacated name slots
	 ./run --rename /mnt/a/foo103 /mnt/a/foo104
	 ./run --rename /mnt/a/foo102 /mnt/a/foo103
	 ./run --rename /mnt/a/foo101 /mnt/a/foo102
	 ./run --rename /mnt/a/foo100 /mnt/a/foo101
	 ./run --rename /mnt/a/foo104 /mnt/a/foo105
	/mnt/a/foo104: File unexpectedly found

strace shows:

	rename("/mnt/a/foo104", "/mnt/a/foo105") = 0
	lstat("/mnt/a/foo104", {st_mode=S_IFREG|0644, st_size=12, ...}) = 0

which shouldn't happen.

The kernel is 17eb601eb5dbc8a2e200872380c03400813d4f1a from overlayfs.v22.

David