From: "Mike Snitzer" <email@example.com>
To: NeilBrown <firstname.lastname@example.org>
Cc: "Andrew Morton" <email@example.com>,
Subject: Re: [PATCH 003 of 3] md: Update md bitmap during resync.
Date: Mon, 10 Dec 2007 15:04:14 -0500 [thread overview]
Message-ID: <firstname.lastname@example.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 838 bytes --]
On Dec 7, 2007 12:42 AM, NeilBrown <email@example.com> wrote:
> Currently and md array with a write-intent bitmap does not updated
> that bitmap to reflect successful partial resync. Rather the entire
> bitmap is updated when the resync completes.
> This is because there is no guarentee that resync requests will
> complete in order, and tracking each request individually is
> unnecessarily burdensome.
> However there is value in regularly updating the bitmap, so add code
> to periodically pause while all pending sync requests complete, then
> update the bitmap. Doing this only every few seconds (the same as the
> bitmap update time) does not notciably affect resync performance.
> Signed-off-by: Neil Brown <firstname.lastname@example.org>
You forgot to export bitmap_cond_end_sync. Please see the attached patch.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: export_bitmap_cond_end_sync.patch --]
[-- Type: text/x-patch; name=export_bitmap_cond_end_sync.patch, Size: 330 bytes --]
diff --git a/drivers/md/bitmap.c b/drivers/md/bitmap.c
index f31ea4f..b596538 100644
@@ -1566,3 +1566,4 @@ EXPORT_SYMBOL(bitmap_start_sync);
prev parent reply other threads:[~2007-12-10 20:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-07 5:41 [PATCH 000 of 3] md: a few little patches NeilBrown
2007-12-07 5:41 ` [PATCH 001 of 3] md: raid6: Fix mktable.c NeilBrown
2007-12-07 5:41 ` [PATCH 002 of 3] md: raid6: clean up the style of raid6test/test.c NeilBrown
2007-12-07 5:42 ` [PATCH 003 of 3] md: Update md bitmap during resync NeilBrown
2007-12-10 20:04 ` Mike Snitzer [this message]
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).