From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964953AbVITJzi (ORCPT ); Tue, 20 Sep 2005 05:55:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964956AbVITJzi (ORCPT ); Tue, 20 Sep 2005 05:55:38 -0400 Received: from H190.C26.B96.tor.eicat.ca ([66.96.26.190]:18624 "EHLO moraine.clusterfs.com") by vger.kernel.org with ESMTP id S964953AbVITJzi (ORCPT ); Tue, 20 Sep 2005 05:55:38 -0400 From: Nikita Danilov MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17199.54982.637650.772991@gargle.gargle.HOWL> Date: Tue, 20 Sep 2005 13:30:46 +0400 To: stephen.pollei@gmail.com Cc: Horst von Brand , Denis Vlasenko , LKML , ReiserFS List Subject: Re: I request inclusion of reiser4 in the mainline kernel In-Reply-To: References: <17197.15183.235861.655720@gargle.gargle.HOWL> <200509192316.j8JNFxY8030819@inti.inf.utfsm.cl> X-Mailer: VM 7.17 under 21.5 (patch 17) "chayote" (+CVS-20040321) XEmacs Lucid Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Stephen Pollei writes: > On 9/19/05, Horst von Brand wrote: > > Nikita Danilov wrote: > > > It's other way around: declaration is guarded by the preprocessor > > > conditional so that nobody accidentally use znode_is_loaded() outside of > > > the debugging mode. > > > > Since when has a missing declaration prevented anyone calling a function in > > C?! It issues a warning, which is enough, given that reiser4 code was warning-free most of the time. > Never AFAIK... K&R, ANSI,ISO C89, c99, whatever version that I know of... > You'd need -Werror and -Wmissing-prototype to make that worth it. > Otherwise the standard says they namesys requested "please make a good No, evil namesys is not responsible for this, Sir. :-) > quess as to what the args are...". > K&R didn't even have the kind of prototypes we know and love today... > So they shouldn't do this half-ass #if/#endif stuff.. either rip it > out, or be a man and make the compile fail when someone calls > znode_is_loaded , if thats what you really want. It's really over > silly anyway, as it will fail at link time if they had matching > preprocessor stuff around the function definition. Failing (with a warning) at compilation is faster. And people are known to went as far as to select major compiler version based on the compilation speed. Nikita.