From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82384C4332F for ; Fri, 25 Nov 2022 11:33:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229994AbiKYLd1 (ORCPT ); Fri, 25 Nov 2022 06:33:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59664 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229541AbiKYLdZ (ORCPT ); Fri, 25 Nov 2022 06:33:25 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4572C183B6 for ; Fri, 25 Nov 2022 03:32:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669375941; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VsGy2+SrkApv7QX3F61FbC2SPRAOik8DhfKcdY40dBI=; b=dZTLqTyMgBix8M0oisfUrVYBmBy2DlZergdsc1SDE6rUsOimOL9xSwMFzn0GjxWsf17DOW 5YR5R4wSwsmevbfK1jmGgZBMN3rhvtSrS1lxmSlAba1KIxupsIUbudnDfXt6Z0MKjkEtV4 1IB9kqzEHOBT2t8ByYaqPICkAFrQouM= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-550-zNN7Xs5rM_KACsLl47gSgw-1; Fri, 25 Nov 2022 06:32:19 -0500 X-MC-Unique: zNN7Xs5rM_KACsLl47gSgw-1 Received: by mail-wm1-f71.google.com with SMTP id bi19-20020a05600c3d9300b003cf9d6c4016so4059047wmb.8 for ; Fri, 25 Nov 2022 03:32:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VsGy2+SrkApv7QX3F61FbC2SPRAOik8DhfKcdY40dBI=; b=33+j26FA5pxrem/6mrfUaZAhqr56MAoV1VSyddE5mN7pNNpjiRiJwDBDNe3fRHwOXr XECaT8rmC5HQWxoxPL1kXGmkRqEF7jtzh8v2zbydu+amPLibCPgorLXIKse5aCrt/Q3x uoylttyJppYKKQPXY6CpJUjtQwgJv3FlyRZjeOMg1v/kDGTM3MvDYlRZqY6WTYodLLdJ CaKHUtreMTCWysHfqb6eXPYBUdk8PMDrFmV+CMrk4VzvjfkSfQL+EZEfa4/nLuvBNjZl rbyuNKm/xiYxRuJYlG2QRd9VEPS2K1X40oN4jIl+peDfVLz89hDF4KFhf47kjAlBMJ7s Pwsg== X-Gm-Message-State: ANoB5pkRLylPgYXLvJw2/jktKOgpLA6utixhxkktEpCx5jvExJZ9MBUT yyvX6OkXTVlEs4ctdycdfOAeEEYGyJM5Jyv+R3UCsIg5V/9DW4nl9cJjmW3xMltcm85hKPBQuK7 rf+lmg6nDt6RwKaNkjNSxUBqA X-Received: by 2002:a05:600c:246:b0:3cf:760a:fbaf with SMTP id 6-20020a05600c024600b003cf760afbafmr14987954wmj.110.1669375938635; Fri, 25 Nov 2022 03:32:18 -0800 (PST) X-Google-Smtp-Source: AA0mqf5OsbzQLyftwLIWI3nDfrRG5jE1JPupjLhaA0WX3eVwlG57KKybql+K8IcZ8fhxJNc3nhLhqQ== X-Received: by 2002:a05:600c:246:b0:3cf:760a:fbaf with SMTP id 6-20020a05600c024600b003cf760afbafmr14987919wmj.110.1669375938413; Fri, 25 Nov 2022 03:32:18 -0800 (PST) Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id x10-20020a05600c21ca00b003a6125562e1sm4484075wmj.46.2022.11.25.03.32.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Nov 2022 03:32:17 -0800 (PST) Message-ID: <171d89b4-fbd9-8df8-5250-5fabd1973960@redhat.com> Date: Fri, 25 Nov 2022 12:32:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH 20/24] drm/vc4: crtc: Provide a CRTC name Content-Language: en-US To: Maxime Ripard , Maxime Ripard , Maarten Lankhorst , Daniel Vetter , David Airlie , Thomas Zimmermann Cc: David Gow , linaro-mm-sig@lists.linaro.org, Greg Kroah-Hartman , linux-kselftest@vger.kernel.org, =?UTF-8?Q?Ma=c3=adra_Canal?= , linux-media@vger.kernel.org, kunit-dev@googlegroups.com, dri-devel@lists.freedesktop.org, Brendan Higgins , linux-kernel@vger.kernel.org, Dave Stevenson References: <20221123-rpi-kunit-tests-v1-0-051a0bb60a16@cerno.tech> <20221123-rpi-kunit-tests-v1-20-051a0bb60a16@cerno.tech> From: Javier Martinez Canillas In-Reply-To: <20221123-rpi-kunit-tests-v1-20-051a0bb60a16@cerno.tech> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/23/22 16:26, Maxime Ripard wrote: > It's fairly hard to figure out the instance of the CRTC affected by an > atomic change using the default name. > > Since we can provide our own to the CRTC initialization functions, let's > do so to make the debugging sessions easier. > > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/vc4/vc4_crtc.c | 10 +++++++++- > drivers/gpu/drm/vc4/vc4_drv.h | 2 ++ > drivers/gpu/drm/vc4/vc4_txp.c | 1 + > 3 files changed, 12 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4/vc4_crtc.c > index 8bc30ad0904b..59e473059fa2 100644 > --- a/drivers/gpu/drm/vc4/vc4_crtc.c > +++ b/drivers/gpu/drm/vc4/vc4_crtc.c > @@ -1118,6 +1118,7 @@ static const struct drm_crtc_helper_funcs vc4_crtc_helper_funcs = { > > static const struct vc4_pv_data bcm2835_pv0_data = { > .base = { > + .name = "pixelvalve-0", I wonder if would make sense to add the SoC name too, but either way: Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat