From: Alexander Duyck <alexander.h.duyck@linux.intel.com>
To: "Kirill A. Shutemov" <kirill@shutemov.name>,
Alexander Duyck <alexander.duyck@gmail.com>
Cc: virtio-dev@lists.oasis-open.org, kvm@vger.kernel.org,
mst@redhat.com, catalin.marinas@arm.com, david@redhat.com,
dave.hansen@intel.com, linux-kernel@vger.kernel.org,
willy@infradead.org, mhocko@kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org, will@kernel.org,
linux-arm-kernel@lists.infradead.org, osalvador@suse.de,
yang.zhang.wz@gmail.com, pagupta@redhat.com,
konrad.wilk@oracle.com, nitesh@redhat.com, riel@surriel.com,
lcapitulino@redhat.com, wei.w.wang@intel.com,
aarcange@redhat.com, ying.huang@intel.com, pbonzini@redhat.com,
dan.j.williams@intel.com, fengguang.wu@intel.com,
kirill.shutemov@linux.intel.com
Subject: Re: [PATCH v9 2/8] mm: Adjust shuffle code to allow for future coalescing
Date: Mon, 09 Sep 2019 09:43:00 -0700 [thread overview]
Message-ID: <171e0e86cde2012e8bda647c0370e902768ba0b5.camel@linux.intel.com> (raw)
In-Reply-To: <20190909094700.bbslsxpuwvxmodal@box>
On Mon, 2019-09-09 at 12:47 +0300, Kirill A. Shutemov wrote:
> On Sat, Sep 07, 2019 at 10:25:20AM -0700, Alexander Duyck wrote:
> > From: Alexander Duyck <alexander.h.duyck@linux.intel.com>
> >
> > Move the head/tail adding logic out of the shuffle code and into the
> > __free_one_page function since ultimately that is where it is really
> > needed anyway. By doing this we should be able to reduce the overhead
> > and can consolidate all of the list addition bits in one spot.
> >
> > Reviewed-by: Dan Williams <dan.j.williams@intel.com>
> > Signed-off-by: Alexander Duyck <alexander.h.duyck@linux.intel.com>
> > ---
> > include/linux/mmzone.h | 12 --------
> > mm/page_alloc.c | 70 +++++++++++++++++++++++++++---------------------
> > mm/shuffle.c | 9 +-----
> > mm/shuffle.h | 12 ++++++++
> > 4 files changed, 53 insertions(+), 50 deletions(-)
> >
> > diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
> > index bda20282746b..125f300981c6 100644
> > --- a/include/linux/mmzone.h
> > +++ b/include/linux/mmzone.h
> > @@ -116,18 +116,6 @@ static inline void add_to_free_area_tail(struct page *page, struct free_area *ar
> > area->nr_free++;
> > }
> >
> > -#ifdef CONFIG_SHUFFLE_PAGE_ALLOCATOR
> > -/* Used to preserve page allocation order entropy */
> > -void add_to_free_area_random(struct page *page, struct free_area *area,
> > - int migratetype);
> > -#else
> > -static inline void add_to_free_area_random(struct page *page,
> > - struct free_area *area, int migratetype)
> > -{
> > - add_to_free_area(page, area, migratetype);
> > -}
> > -#endif
> > -
> > /* Used for pages which are on another list */
> > static inline void move_to_free_area(struct page *page, struct free_area *area,
> > int migratetype)
>
> Looks like add_to_free_area() and add_to_free_area_tail() can be moved to
> mm/page_alloc.c as all users are there now. And the same for struct
> free_area definition (but not declaration).
This can probably be worked into patch 4 instead of doing it here. I could
pull all the functions that are renamed to _free_list from _free_area into
page_alloc.c and leave behind the ones that remained as _free_area such as
get_page_from_free_area. That should make it easier for me to avoid having
to include page_reporting.h in mmzone.h.
I'm not sure I follow what you are saying about the free_area definition.
It looks like it is a part of the zone structure so I would think it still
needs to be defined in the header.
next prev parent reply other threads:[~2019-09-09 16:43 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-07 17:25 [PATCH v9 0/8] stg mail -e --version=v9 \ Alexander Duyck
2019-09-07 17:25 ` [PATCH v9 1/8] mm: Add per-cpu logic to page shuffling Alexander Duyck
2019-09-09 8:14 ` David Hildenbrand
2019-09-09 15:11 ` Alexander Duyck
2019-09-10 12:11 ` Michal Hocko
2019-09-10 22:14 ` Alexander Duyck
2019-09-10 22:11 ` Alexander Duyck
2019-09-09 9:07 ` Kirill A. Shutemov
2019-09-09 15:12 ` Alexander Duyck
2019-09-07 17:25 ` [PATCH v9 2/8] mm: Adjust shuffle code to allow for future coalescing Alexander Duyck
2019-09-09 8:19 ` David Hildenbrand
2019-09-09 9:47 ` Kirill A. Shutemov
2019-09-09 15:22 ` Alexander Duyck
2019-09-09 15:35 ` Kirill A. Shutemov
2019-09-09 15:37 ` Alexander Duyck
2019-09-09 16:43 ` Alexander Duyck [this message]
2019-09-09 17:00 ` Kirill A. Shutemov
2019-09-10 12:20 ` Michal Hocko
2019-09-10 14:48 ` Alexander Duyck
2019-09-07 17:25 ` [PATCH v9 3/8] mm: Move set/get_pcppage_migratetype to mmzone.h Alexander Duyck
2019-09-09 8:22 ` David Hildenbrand
2019-09-09 9:56 ` Kirill A. Shutemov
2019-09-09 18:01 ` Alexander Duyck
2019-09-09 18:12 ` Alexander Duyck
2019-09-10 12:23 ` Michal Hocko
2019-09-10 14:46 ` Alexander Duyck
2019-09-10 17:45 ` Michal Hocko
2019-09-10 20:26 ` Alexander Duyck
2019-09-07 17:25 ` [PATCH v9 4/8] mm: Use zone and order instead of free area in free_list manipulators Alexander Duyck
2019-09-10 12:27 ` Michal Hocko
2019-09-07 17:25 ` [PATCH v9 5/8] arm64: Move hugetlb related definitions out of pgtable.h to page-defs.h Alexander Duyck
2019-09-09 8:52 ` David Hildenbrand
2019-09-09 15:27 ` Alexander Duyck
2019-09-17 17:48 ` Will Deacon
2019-09-17 20:07 ` Alexander Duyck
2019-09-07 17:25 ` [PATCH v9 6/8] mm: Introduce Reported pages Alexander Duyck
2019-09-09 14:42 ` Kirill A. Shutemov
2019-09-09 16:25 ` Alexander Duyck
2019-09-09 16:33 ` Kirill A. Shutemov
2019-09-07 17:26 ` [PATCH v9 7/8] virtio-balloon: Pull page poisoning config out of free page hinting Alexander Duyck
2019-09-09 8:59 ` David Hildenbrand
2019-09-09 15:31 ` Alexander Duyck
2019-09-07 17:26 ` [PATCH v9 8/8] virtio-balloon: Add support for providing unused page reports to host Alexander Duyck
2019-09-07 17:34 ` [PATCH v9 0/8] mm / virtio: Provide support for unused page reporting Alexander Duyck
2019-09-10 12:42 ` [PATCH v9 0/8] stg mail -e --version=v9 \ Michal Hocko
2019-09-10 14:42 ` Alexander Duyck
2019-09-10 14:47 ` Michal Hocko
2019-09-10 16:05 ` Alexander Duyck
2019-09-10 16:18 ` [virtio-dev] " Dr. David Alan Gilbert
2019-09-10 16:22 ` David Hildenbrand
2019-09-11 9:23 ` Michael S. Tsirkin
2019-09-11 9:50 ` David Hildenbrand
2019-09-10 17:52 ` Michal Hocko
2019-09-10 18:00 ` Michal Hocko
2019-09-10 20:37 ` Alexander Duyck
2019-09-10 21:23 ` Alexander Duyck
2019-09-11 11:36 ` Michal Hocko
2019-09-11 11:47 ` David Hildenbrand
2019-09-11 12:08 ` Michael S. Tsirkin
2019-09-11 12:19 ` Michal Hocko
2019-09-11 12:25 ` Michal Hocko
2019-09-11 12:42 ` David Hildenbrand
2019-09-11 12:54 ` Michal Hocko
2019-09-11 13:03 ` David Hildenbrand
2019-09-11 13:20 ` Michal Hocko
2019-09-11 13:51 ` Michal Hocko
2019-09-11 16:09 ` David Hildenbrand
2019-09-12 7:16 ` Michal Hocko
2019-09-12 7:47 ` David Hildenbrand
2019-09-12 9:26 ` Michal Hocko
2019-09-12 12:00 ` Nitesh Narayan Lal
2019-09-11 14:03 ` Nitesh Narayan Lal
2019-09-11 16:02 ` David Hildenbrand
2019-09-11 13:19 ` Nitesh Narayan Lal
2019-09-11 12:55 ` Nitesh Narayan Lal
2019-09-11 15:12 ` Alexander Duyck
2019-09-12 9:19 ` Michal Hocko
2019-09-12 10:24 ` Kirill A. Shutemov
2019-09-12 11:11 ` Michal Hocko
2019-09-12 15:42 ` Alexander Duyck
2019-09-12 16:35 ` Mel Gorman
2019-09-12 17:48 ` Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171e0e86cde2012e8bda647c0370e902768ba0b5.camel@linux.intel.com \
--to=alexander.h.duyck@linux.intel.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.duyck@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@intel.com \
--cc=david@redhat.com \
--cc=fengguang.wu@intel.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=kirill@shutemov.name \
--cc=konrad.wilk@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=lcapitulino@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mst@redhat.com \
--cc=nitesh@redhat.com \
--cc=osalvador@suse.de \
--cc=pagupta@redhat.com \
--cc=pbonzini@redhat.com \
--cc=riel@surriel.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=wei.w.wang@intel.com \
--cc=will@kernel.org \
--cc=willy@infradead.org \
--cc=yang.zhang.wz@gmail.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).