From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752704AbbDCKke (ORCPT <rfc822;w@1wt.eu>);
	Fri, 3 Apr 2015 06:40:34 -0400
Received: from v094114.home.net.pl ([79.96.170.134]:60735 "HELO
	v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with SMTP id S1752530AbbDCKkc (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 3 Apr 2015 06:40:32 -0400
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Guenter Roeck <linux@roeck-us.net>, Wim Van Sebroeck <wim@iguana.be>
Cc: linux-watchdog@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux PM list <linux-pm@vger.kernel.org>,
        Aubrey Li <aubrey.li@intel.com>, Borun Fu <borun.fu@intel.com>
Subject: Re: [PATCH] PM / watchdog: iTCO: stop watchdog during system suspend
Date: Fri, 03 Apr 2015 13:04:47 +0200
Message-ID: <1741516.p64k4HnZLy@vostro.rjw.lan>
User-Agent: KMail/4.11.5 (Linux/3.19.0+; KDE/4.11.5; x86_64; ; )
In-Reply-To: <551E29B7.7050801@roeck-us.net>
References: <2017660.nPaHVT8bW3@vostro.rjw.lan> <2928815.XiLbVYtUVn@vostro.rjw.lan> <551E29B7.7050801@roeck-us.net>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="utf-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thursday, April 02, 2015 10:48:39 PM Guenter Roeck wrote:
> On 04/02/2015 03:04 PM, Rafael J. Wysocki wrote:
> [ ... ]
> >
> > ---
> > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > Subject: PM / watchdog: iTCO: stop watchdog during system suspend
> >
> > If the target sleep state of the system is not an ACPI sleep state
> > (S1, S2 or S3), the TCO watchdog needs to be stopped during system
> > suspend, because it may not be possible to ping it any more after
> > timekeeping has been suspended (suspend-to-idle does that for
> > one example).
> >
> > For this reason, provide ->suspend_noirq and ->resume_noirq
> > callbacks for the iTCO watchdog driver and use them to stop
> > and restart the watchdog during system suspend and resume,
> > respectively, if the system is not going to enter an ACPI
> > sleep state (in which case the watchdog will be stopped
> > by the platform firmware before the state is entered).
> >
> > Reported-by: Borun Fu <borun.fu@intel.com>
> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>

Thanks!

I'll take it into the PM tree, unless anyone objects.

Rafael