From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5E2EC4361A for ; Fri, 4 Dec 2020 01:29:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5B729207D1 for ; Fri, 4 Dec 2020 01:29:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727556AbgLDB2u convert rfc822-to-8bit (ORCPT ); Thu, 3 Dec 2020 20:28:50 -0500 Received: from smtp.h3c.com ([60.191.123.50]:2010 "EHLO h3cspam02-ex.h3c.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726158AbgLDB2u (ORCPT ); Thu, 3 Dec 2020 20:28:50 -0500 Received: from DAG2EX02-BASE.srv.huawei-3com.com ([10.8.0.65]) by h3cspam02-ex.h3c.com with ESMTP id 0B41RCuI075840; Fri, 4 Dec 2020 09:27:12 +0800 (GMT-8) (envelope-from tian.xianting@h3c.com) Received: from DAG2EX03-BASE.srv.huawei-3com.com (10.8.0.66) by DAG2EX02-BASE.srv.huawei-3com.com (10.8.0.65) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Fri, 4 Dec 2020 09:27:13 +0800 Received: from DAG2EX03-BASE.srv.huawei-3com.com ([fe80::5d18:e01c:bbbd:c074]) by DAG2EX03-BASE.srv.huawei-3com.com ([fe80::5d18:e01c:bbbd:c074%7]) with mapi id 15.01.2106.002; Fri, 4 Dec 2020 09:27:13 +0800 From: Tianxianting To: "Theodore Y. Ts'o" , Jan Kara CC: "adilger.kernel@dilger.ca" , "linux-ext4@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] ext4: remove the null check of bio_vec page Thread-Topic: [PATCH] ext4: remove the null check of bio_vec page Thread-Index: AQHWpruDhYzwIts0bkGkoCqDPV0JCqmhVUyAgEPTgYCAAULUUA== Date: Fri, 4 Dec 2020 01:27:13 +0000 Message-ID: <1758a0c58d174070915534f538aaf52d@h3c.com> References: <20201020082201.34257-1-tian.xianting@h3c.com> <20201021102503.GC19726@quack2.suse.cz> <20201203141127.GF441757@mit.edu> In-Reply-To: <20201203141127.GF441757@mit.edu> Accept-Language: en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.99.141.128] x-sender-location: DAG2 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-DNSRBL: X-MAIL: h3cspam02-ex.h3c.com 0B41RCuI075840 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks Ted :) -----Original Message----- From: Theodore Y. Ts'o [mailto:tytso@mit.edu] Sent: Thursday, December 03, 2020 10:11 PM To: Jan Kara Cc: tianxianting (RD) ; adilger.kernel@dilger.ca; linux-ext4@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH] ext4: remove the null check of bio_vec page On Wed, Oct 21, 2020 at 12:25:03PM +0200, Jan Kara wrote: > On Tue 20-10-20 16:22:01, Xianting Tian wrote: > > bv_page can't be NULL in a valid bio_vec, so we can remove the NULL > > check, as we did in other places when calling > > bio_for_each_segment_all() to go through all bio_vec of a bio. > > > > Signed-off-by: Xianting Tian > > Thanks for the patch. It looks good to me. You can add: > > Reviewed-by: Jan Kara Applied, thanks. - Ted